Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave room feature #7

Closed
armagandalkiran opened this issue Nov 8, 2023 · 5 comments
Closed

Leave room feature #7

armagandalkiran opened this issue Nov 8, 2023 · 5 comments
Assignees
Labels
app: client Client project folder app: server Server project folder epic: grooming page Grooming page epic type: feature New feature or request

Comments

@armagandalkiran
Copy link
Collaborator

armagandalkiran commented Nov 8, 2023

Tasks

Implement leave room feature

Why do we need this?

Users may accidentally enter rooms so they might want to change room.

Implementation Considerations

  • Pay attention to the use of CSS variables in the codebase.
  • Ensure proper naming conventions for properties such as color, font-size, or font-weight when adding them to the variable.scss file.

Scope

Develop leave room feature according to Figma design for ongoing grooming sessions.
There are todos for both server and client side:

For client-side:

You should implement new menu opened when user click to his/her profile name.
After that when user click leave room you should implement new popup.
If user clicks close, close the popup and the menu.
If user clicks leave, you should send event to server and listen it, after that redirect user to home.

For server-side:
You should implement an event handler and clear user from the current grooming session.

Design Link

View Design

Questions or Issues

If you still have questions, feel free to comment within the relevant issue. You can tag @armagandalkiran and @aahmetcakir for assistance.

@armagandalkiran armagandalkiran added the type: feature New feature or request label Nov 8, 2023
@hsglc
Copy link
Contributor

hsglc commented Feb 6, 2024

Hey @armagandalkiran, Is this task being done? If this is not done, I can do it

@armagandalkiran
Copy link
Collaborator Author

Hi @hsglc , @aahmetcakir is working on the ui part of this task so development task is not ready yet 🤘

@armagandalkiran armagandalkiran added this to the New UI Development milestone Feb 7, 2024
@armagandalkiran armagandalkiran added app: client Client project folder app: server Server project folder epic: grooming page Grooming page epic labels Feb 7, 2024
@armagandalkiran
Copy link
Collaborator Author

hi @hsglc , if you still want to implement this issue it is now ready! I can assign it to you please let me now.

Warning: This is going to be a full-stack development

@hsglc
Copy link
Contributor

hsglc commented Feb 7, 2024

hi @hsglc , if you still want to implement this issue it is now ready! I can assign it to you please let me now.

Warning: This is going to be a full-stack development

hi @armagandalkiran, yeap you can assign it to me.

@armagandalkiran
Copy link
Collaborator Author

I assigned it thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: client Client project folder app: server Server project folder epic: grooming page Grooming page epic type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants