add github action workflow files and linter settings #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulumseraslann
force-pushed
the
workflow-action
branch
from
6a29dce to
c6d35c1
Compare
gulumseraslann
force-pushed
the
workflow-action
branch
from
c6d35c1 to
cf1ff79
Compare
gunerhuseyin
requested changes
Nov 19, 2022
| @@ -0,0 +1,7 @@ | |||
| package godcpclient | |||
There was a problem hiding this comment.
This project will be used as a package, so we don't need to main.go
| version: v1.50 | ||
| args: -c .golangci.yml -v | ||
|
|
||
| - name: Build |
| - unconvert | ||
| - unparam | ||
| - unused | ||
| - whitespace |
There was a problem hiding this comment.
You should add these:
- staticcheck
- typecheck
- varcheck
- structcheck
- vet
- vetshadow
|
|
||
| jobs: | ||
|
|
||
| build: |
There was a problem hiding this comment.
Maybe you can rename it to ci, and also rename this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.