Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacheck.php hidden system support #801

Open
yakra opened this issue Oct 19, 2024 · 2 comments
Open

datacheck.php hidden system support #801

yakra opened this issue Oct 19, 2024 · 2 comments
Assignees

Comments

@yakra
Copy link
Contributor

yakra commented Oct 19, 2024

Preliminary support for hidden systems is on tmtest for the moment:
https://tmtest.teresco.org/devel/datacheck.php?show=COMBINE_CON_ROUTES

System & Region filtering are broken, most likely due to trying to JOIN on a route not in the DB.

Would have to either

  • add hidden system info to the DB, which I'm not thrilled about, or
  • add new columns to the datacheckErrors tabke for system & region. I like this better
@michihdeu
Copy link
Contributor

The first showroute link at COMBINE_CON_ROUTES for hidden systems is missing. It's fine for preview and devel. Dunno about active. @yakra

@yakra
Copy link
Contributor Author

yakra commented Oct 19, 2024

I know, noted over here.

This problem is not actually that the 1st one is missing, but that the 2nd one was still there.
Neither should be there for hidden systems, which don't go in the DB at all.

If you still have the page open (it's been updated) and you still have a link in the Info column for a hidden route, click on it and you'll get a broken showroute page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants