Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX: text outside popup edges (low priority) #176

Open
yakra opened this issue Jun 6, 2018 · 6 comments
Open

HDX: text outside popup edges (low priority) #176

yakra opened this issue Jun 6, 2018 · 6 comments
Assignees

Comments

@yakra
Copy link
Collaborator

yakra commented Jun 6, 2018

johnbrord-128

Everything works, and I can even select the text; more cosmetic than anything.
Low priority.
I saw this exact same behavior in Firefox, Chromium, and Chrome.

@jteresco
Copy link
Contributor

jteresco commented Jun 6, 2018

Looks like we just need to set maxWidth of the popups to something larger than the default 300. Do we want it so large that even ridiculously long labels will fit?

@yakra
Copy link
Collaborator Author

yakra commented Jun 6, 2018

Smaller font size?

@jteresco
Copy link
Contributor

jteresco commented Jun 6, 2018

I will go with a combination of the two. It looks like Leaflet popups can easily be configured to sprout a vertical scrollbar if their contents are too tall, but I don't see a way to have them scroll horizontally when the contents are too wide.

@jteresco jteresco self-assigned this Jun 6, 2018
@jteresco
Copy link
Contributor

jteresco commented Dec 18, 2020

This is a TM problem showing up in HDX. The markerInfo function in tmjsfuncs.js could reduce the font size beyond a given length, or try to introduce breaks in the label so it would wraparound. I am less excited about having a shortened version of the label with mouseover to bring up the full label, as I think that would complicate attempts for copy and paste of labels (in case anyone does that).

@jteresco
Copy link
Contributor

Leaving this open for now, but further discussion should be in TravelMapping/Web#563

@yakra
Copy link
Collaborator Author

yakra commented Dec 18, 2020

I think that would complicate attempts for copy and paste of labels (in case anyone does that).

*raises hand*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants