Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_master_tmg #200

Closed
yakra opened this issue Mar 29, 2019 · 3 comments · Fixed by #258
Closed

write_master_tmg #200

yakra opened this issue Mar 29, 2019 · 3 comments · Fixed by #258

Comments

@yakra
Copy link
Contributor

yakra commented Mar 29, 2019

#185 combined writing simple & collapsed graphs into a single function.
With the introduction of traveled format graphs, this function now handles all three formats.

Similarly combining the three master graphs into a single function could save us a wee bit of time, and simplify the code.

@yakra
Copy link
Contributor Author

yakra commented Apr 2, 2019

Functions for vertex & edge counts can be consolidated, for a (tiny) bit of time savings.

Matching edge functions can probably also be consolidated, to squeeze a little more efficiency out of subgraph generation. <--This should be its own issue.

@yakra
Copy link
Contributor Author

yakra commented Jun 28, 2019

#236 takes care of the OP.

Functions for vertex & edge counts can be consolidated, for a (tiny) bit of time savings.

Still on the to-do list. Leaving this issue open.

@yakra
Copy link
Contributor Author

yakra commented Nov 8, 2019

I didn't like the way the multithreaded C++ siteupdate.log was affected in #238, so I redid things.

epoch:

HighwayData @ ee4a688eff41329fd02a5823feac2cfc1227fac2
UserData @ 1377e062d3d3990bea11ed5ed63ee7bf4f4fe66b

  • Python: 29.7 -> 27.5 s, an 8% speedup
  • C++: 11.45 -> 9.4 s, a 21.8% speedup

noreaster:

HighwayData @ 1d043ba5c2717ee3b451e71320945f7aa4c8e6c4
UserData @ 83a47aee090102cd598b385d8174fd9ed4513415

  • Python: 22.9 -> 21.2 s, an 8% speedup
  • C++: not tested (yet?)

A little more testing on BiggaTomato to ensure multithreaded still looks OK, and then a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant