Skip to content

Commit aad4413

Browse files
committed
Merge branch 'Varorbc-issue-30'
2 parents e37c178 + 13715b4 commit aad4413

26 files changed

+311
-336
lines changed

sample/ScaffoldingSample.Api/ScaffoldingSample.Api.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.3" />
9+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.9" />
1010
</ItemGroup>
1111

1212
<ItemGroup>

sample/ScaffoldingSample.Embedded/ScaffoldingSample.Embedded.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.3" />
10-
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.3" />
9+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.9" />
10+
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.9" />
1111
</ItemGroup>
1212

1313
<ItemGroup>

sample/ScaffoldingSample.TypeScript/ScaffoldingSample.TypeScript.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.3" />
10-
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.3" />
9+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.9" />
10+
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.9" />
1111
</ItemGroup>
1212

1313
<ItemGroup>

sample/ScaffoldingSample/ScaffoldingDesignTimeServices.cs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
using System;
22
using System.Collections.Generic;
3-
using System.Diagnostics;
4-
using System.IO;
53
using EntityFrameworkCore.Scaffolding.Handlebars;
64
using HandlebarsDotNet;
75
using Microsoft.EntityFrameworkCore.Design;
@@ -50,10 +48,10 @@ public void ConfigureDesignTimeServices(IServiceCollection services)
5048
});
5149

5250
// Register Handlebars helper
53-
var myHelper = (helperName: "my-helper", helperFunction: (Action<TextWriter, Dictionary<string, object>, object[]>)MyHbsHelper);
51+
var myHelper = (helperName: "my-helper", helperFunction: (Action<EncodedTextWriter, Context, Arguments>)MyHbsHelper);
5452

5553
// Register Handlebars block helper
56-
var ifCondHelper = (helperName: "ifCond", helperFunction: (Action<TextWriter, HelperOptions, Dictionary<string, object>, object[]>)MyHbsBlockHelper);
54+
var ifCondHelper = (helperName: "ifCond", helperFunction: (Action<EncodedTextWriter, BlockHelperOptions, Context, Arguments>)MyHbsBlockHelper);
5755

5856
// Add optional Handlebars helpers
5957
services.AddHandlebarsHelpers(myHelper);
@@ -76,17 +74,17 @@ public void ConfigureDesignTimeServices(IServiceCollection services)
7674
}
7775

7876
// Sample Handlebars helper
79-
void MyHbsHelper(TextWriter writer, Dictionary<string, object> context, object[] parameters)
77+
void MyHbsHelper(EncodedTextWriter writer, Context context, Arguments parameters)
8078
{
8179
writer.Write("// My Handlebars Helper");
8280
}
8381

8482
// Sample Handlebars block helper
85-
void MyHbsBlockHelper(TextWriter writer, HelperOptions options, Dictionary<string, object> context, object[] args)
83+
void MyHbsBlockHelper(EncodedTextWriter writer, BlockHelperOptions options, Context context, Arguments args)
8684
{
87-
var val0str = args?[0]?.ToString();
88-
var val1str = args?[1]?.ToString();
89-
var val2str = args?[2]?.ToString();
85+
var val0str = args[0]?.ToString();
86+
var val1str = args[1]?.ToString();
87+
var val2str = args[2]?.ToString();
9088
var val1 = float.Parse(val0str ?? "0");
9189
var val2 = float.Parse(val2str ?? "0");
9290

sample/ScaffoldingSample/ScaffoldingSample.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.3" />
11-
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.3" />
10+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.9" />
11+
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.9" />
1212
</ItemGroup>
1313

1414
<ItemGroup>

src/EntityFrameworkCore.Scaffolding.Handlebars/EmbeddedResourceTemplateFileService.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,8 @@ public override string RetrieveTemplateFileContents(string relativeDirectory, st
3030
string resourceLocation = $"{_namespace}.{relativeDirectory.Replace('/', '.')}.{fileName}";
3131
using (var stream = _assembly.GetManifestResourceStream(resourceLocation))
3232
{
33-
using (var reader = new StreamReader(stream))
34-
{
35-
content = reader.ReadToEnd();
36-
}
33+
using var reader = new StreamReader(stream);
34+
content = reader.ReadToEnd();
3735
}
3836

3937
return content;

src/EntityFrameworkCore.Scaffolding.Handlebars/EntityFrameworkCore.Scaffolding.Handlebars.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@
5656
</ItemGroup>
5757

5858
<ItemGroup>
59-
<PackageReference Include="Handlebars.Net" Version="1.11.5" />
60-
<PackageReference Include="JetBrains.Annotations" Version="2020.3.0" />
61-
<PackageReference Include="Microsoft.EntityFrameworkCore.Abstractions" Version="5.0.3" />
62-
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.3" />
59+
<PackageReference Include="Handlebars.Net" Version="2.0.9" />
60+
<PackageReference Include="JetBrains.Annotations" Version="2021.2.0" />
61+
<PackageReference Include="Microsoft.EntityFrameworkCore.Abstractions" Version="5.0.9" />
62+
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="5.0.9" />
6363
</ItemGroup>
6464

6565
<ItemGroup>

src/EntityFrameworkCore.Scaffolding.Handlebars/GlobalSuppressions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "type", Target = "~T:EntityFrameworkCore.Scaffolding.Handlebars.HbsCSharpEntityTypeGenerator")]
1212
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "type", Target = "~T:EntityFrameworkCore.Scaffolding.Handlebars.HbsReverseEngineerScaffolder")]
1313
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "type", Target = "~T:EntityFrameworkCore.Scaffolding.Handlebars.HbsTypeScriptEntityTypeGenerator")]
14-
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "member", Target = "~M:EntityFrameworkCore.Scaffolding.Handlebars.HbsTypeScriptEntityTypeGenerator_Old.GenerateProperties(Microsoft.EntityFrameworkCore.Metadata.IEntityType)")]
1514
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "type", Target = "~T:EntityFrameworkCore.Scaffolding.Handlebars.NullCSharpDbContextGenerator")]
1615
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "member", Target = "~M:Microsoft.EntityFrameworkCore.Design.ServiceCollectionExtensions.AddHandlebarsScaffolding(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{EntityFrameworkCore.Scaffolding.Handlebars.HandlebarsScaffoldingOptions})~Microsoft.Extensions.DependencyInjection.IServiceCollection")]
1716
[assembly: SuppressMessage("Usage", "EF1001:Internal EF Core API usage.", Justification = "<Pending>", Scope = "type", Target = "~T:EntityFrameworkCore.Scaffolding.Handlebars.NullCSharpEntityTypeGenerator")]

src/EntityFrameworkCore.Scaffolding.Handlebars/HbsBlockHelperService.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System;
22
using System.Collections.Generic;
3-
using System.IO;
43
using HandlebarsDotNet;
54

65
namespace EntityFrameworkCore.Scaffolding.Handlebars
@@ -13,14 +12,13 @@ public class HbsBlockHelperService : IHbsBlockHelperService
1312
/// <summary>
1413
/// Handlebars block helpers.
1514
/// </summary>
16-
public Dictionary<string, Action<TextWriter, HelperOptions, Dictionary<string, object>, object[]>> Helpers { get; }
15+
public Dictionary<string, Action<EncodedTextWriter, BlockHelperOptions, Context, Arguments>> Helpers { get; }
1716

1817
/// <summary>
1918
/// Constructor for the Handlebars block helper service.
2019
/// </summary>
2120
/// <param name="helpers">Dictionary of Handlebars helpers.</param>
22-
public HbsBlockHelperService(
23-
Dictionary<string, Action<TextWriter, HelperOptions, Dictionary<string, object>, object[]>> helpers)
21+
public HbsBlockHelperService(Dictionary<string, Action<EncodedTextWriter, BlockHelperOptions, Context, Arguments>> helpers)
2422
{
2523
Helpers = helpers;
2624
}

src/EntityFrameworkCore.Scaffolding.Handlebars/HbsCSharpEntityTypeGenerator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ private static string StripAttribute(string attributeName)
633633
{
634634
if (attributeName == null) throw new ArgumentNullException(nameof(attributeName));
635635
return attributeName.EndsWith("Attribute", StringComparison.Ordinal)
636-
? attributeName.Substring(0, attributeName.Length - 9)
636+
? attributeName[0..^9]
637637
: attributeName;
638638
}
639639
}

0 commit comments

Comments
 (0)