Skip to content

Detect changes as a result of Bazel runs - #2294

Merged
palfrey merged 1 commit into
TraceMachina:mainfrom
palfrey:detect-bazel-changes
May 1, 2026
Merged

palfrey merged 1 commit into
TraceMachina:mainfrom
palfrey:detect-bazel-changes

Conversation

@palfrey

@palfrey palfrey commented Apr 30, 2026 •

Copy link
Copy Markdown
Member

Description

Main item here was picking up changes to MODULE.bazel.lock. See example run at https://github.com/TraceMachina/nativelink/actions/runs/25171818162/job/73793030412?pr=2294

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Comment thread .gitignore Outdated
@palfrey
palfrey marked this pull request as ready for review April 30, 2026 17:00

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errant line is very strange, leading me to look further into the lock file itself.

@MarcusSorealheis

Copy link
Copy Markdown
Member

Maybe try running this:

bazel clean
bazel build //... 2>&1
ls -la bc  # check timestamp and type

@jsharpe

jsharpe commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

You can use https://bazel.build/reference/command-line-reference#common_options-flag--lockfile_mode specifically for MODULE.bazel.lock file changes - pass --lockfile_mode=error in CI.

@palfrey
palfrey force-pushed the detect-bazel-changes branch from a914e8d to 89fcaec Compare May 1, 2026 09:48
@palfrey

palfrey commented May 1, 2026

Copy link
Copy Markdown
Member Author

Maybe try running this:

bazel clean
bazel build //... 2>&1
ls -la bc  # check timestamp and type

This gets nothing locally. I've seen this before in Github actions runs, I think it's Github-specific.

@palfrey

palfrey commented May 1, 2026

Copy link
Copy Markdown
Member Author

You can use https://bazel.build/reference/command-line-reference#common_options-flag--lockfile_mode specifically for MODULE.bazel.lock file changes - pass --lockfile_mode=error in CI.

Nice! Didn't know about that one. I've switched out the git diff work for adding this to all the Bazel calls in the workflows.

@palfrey
palfrey requested a review from MarcusSorealheis May 1, 2026 10:32
@palfrey
palfrey force-pushed the detect-bazel-changes branch from 89fcaec to 079a8c3 Compare May 1, 2026 11:36
@palfrey
palfrey merged commit 48bd42b into TraceMachina:main May 1, 2026
34 checks passed
@palfrey
palfrey deleted the detect-bazel-changes branch May 1, 2026 12:23
rejuvenile pushed a commit to rejuvenile/nativelink that referenced this pull request Aug 19, 2026

This branch was previously deployed

1 inactive deployment
production — 079a8c37 Deployed May 1, 2026 by palfrey via Web Platform Deployment / ubuntu-24.04 #2412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants