-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Authentication with CaddyServer is not working for minio store #10
Comments
Did you try using the official way of using minio + caddy from minio docs? Whats the problem exactly? Which part does not work (artifacts upload from cli/python or download from mlflow ui?). Could you post some diagram which represents the problematic situation? How did you try to diagnose it? About the idea of showing ready to launch service with authenticationYeah, thats basically what the readme says (so the authentication should be baked into the project)... I need to think about adding the authentication, but in a way that will be super modular, and wont require big changes in the project to change the way its distributed. |
Hi Toumash, thanks for answering! The official way of using minio+caddy that you linked, is outdated, sadly. It is written for Caddyserver v.1.
opening my-url.com in the browser redirects me to the MinIO-console-UI at port 9001, but the connection is is marked "not secure" in the address-bar. When I replace 's3:9000 ' with 'mlflow:5000' for the MLflow-tracking, everything works fine and the connection is secure. About the idea: I don't know if you are familiar with Caddyserver, but apart from MinIO it is very easy to get a secure basic authentication up and running! So if you think this would be well-received on youtube, you should go for it :) |
Im gonna see whats the problem tomorrow. In the meantime please post your docker-compose with caddyserver setup. |
Caddyfile (the 'basicauth' expression can be left out):
docker-compose for Caddy:
docker-compose for MLflow (I use the one from this project, just added the "proxy-net"-network to make the services accessible to Caddy):
|
Hi, did you have a chance to look at the issue yet? I had no success in resolving it yet and am now considering to switch to a SFTP-artifact store :( |
I dont get one thing: about what insecure connection you are talking about? I cannot run any code to connect to mlflow tracking, cause for some reason i cannot just trust my local caddy certificate (im on windows), but i dont see that something would block it |
Sorry for the delayed answer, I was very busy lately. |
I've linked the PR #11 Let me know if that helps |
Thanks for your implementation @Toumash, that certainly helped! :) |
@Clemens123 Docs are clear about this: https://caddyserver.com/docs/automatic-https Unfortunately i dont have access to any any machine where i could test this out. Can you please provice an example? |
So you are suggesting that changing the Caddy-file to
would work? I.e. it would process an initial API-request at port 9000 by first establishing a connection over port 443 (https) and then forwarding the request to the s3-service? |
@Clemens123 I mean if you have domain name routing, then you can just host the minio api to the mentioned If you already have ssl certificate you could use it without taking the api public https://caddy.community/t/custom-ssl-certificate/6981 |
Hi, I tried to run it today and it seems like it should work. Sadly, I got an error now even though the AWS-credentials on the client are 100% the same as in the .env-file. |
Do you have the same error on the master branch? Watch out, it removes data from containers
Merry Christmas and Happy New Year ^^
|
@Clemens123 any update on this? |
Hi @Toumash , sorry for the late answer: I'm extremely busy at the moment and don't know yet when I will find the time to look into it again, deeply sorry :( I hope maybe in 2 weeks? |
Closing due to inactivity. The PR will be open for anyone to get in and develop further |
Hi, love your project, thank you very much for the effort you put in!
I'm trying to add secure authentication to the MLflow-Server and am using Caddy (https://caddyserver.com/) as a reverse proxy.
For MLflow it works fine, but the MinIO-Artifact-Store is just not accessible behind the reverse proxy, I don't know why.
The point is, I need to have access to MLflow Tracking savely online.
Do you have any ideas or suggestions?
Could be a cool addon to the project, too, for people to learn about reverse proxies.
Thanks and best regards!
Clemens
The text was updated successfully, but these errors were encountered: