cors: support cross-site access to socket.io #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A description of the changes proposed in the pull request and why
This PR enables cross-site access to uibuilder, for example so one can serve the front-end UI code from a standard javascript dev server running on one's laptop, such as using
vue-cli-service serve. By default socket.io allows cross-site access, however, uibuilder sends an x-clientid custom header which must be explicitly included in the CORS preflight response. IMHO this PR does not reduce security because cross-site access was already allowed, it just didn't work out of the box: an attacker could have simply dropped the x-clientid header to get through.Environment used for development and testing