Update

Author: Alexr03

Controllers/CronsController.cs

@@ -1,8 +1,8 @@
 using System.Linq;
 using System.Web.Mvc;
+using Alexr03.Common.TCAdmin.Web.Binders;
 using Alexr03.Common.Web.Helpers;
 using Newtonsoft.Json.Linq;
-using TCAdmin.SDK.Objects;
 using TCAdmin.SDK.VirtualFileSystem;
 using TCAdmin.SDK.Web.FileManager;
 using TCAdmin.SDK.Web.MVC.Controllers;
@@ -17,14 +17,13 @@ public ActionResult Configuration()
         {
             return View();
         }
-        
+
         [ParentAction("Configuration")]
-        public ActionResult ConfigureCron(int id)
+        public ActionResult ConfigureCron([DynamicTypeBaseBinder] CronJob cronJob)
         {
-            var cronJob = new CronJob(id);
-            TempData["id"] = id;
+            TempData["id"] = cronJob.Id;
             TempData["repeatEvery"] = cronJob.ExecuteEverySeconds;
-            var configurationJObject = (JObject)cronJob.Configuration.Parse<object>();
+            var configurationJObject = cronJob.Configuration.Parse<JObject>();
             var o = configurationJObject.ToObject(cronJob.Configuration.Type);
             ViewData.TemplateInfo = new TemplateInfo
             {
@@ -35,12 +34,11 @@ public ActionResult ConfigureCron(int id)
 
         [HttpPost]
         [ParentAction("Configuration")]
-        public ActionResult ConfigureCron(int id, FormCollection model)
+        public ActionResult ConfigureCron([DynamicTypeBaseBinder] CronJob cronJob, FormCollection model)
         {
-            var cronJob = new CronJob(id);
             cronJob.ExecuteEverySeconds = int.Parse(Request[$"{cronJob.Configuration.Type.Name}.repeatEvery"]);
             cronJob.Save();
-            TempData["id"] = id;
+            TempData["id"] = cronJob.Id;
             TempData["repeatEvery"] = cronJob.ExecuteEverySeconds;
             var bindModel = model.Parse(ControllerContext, cronJob.Configuration.Type);
             cronJob.Configuration.SetConfiguration(bindModel);

Crons/GameUpdates/MinecraftBukkitUpdatesCron.cs

@@ -15,7 +15,7 @@ public class MinecraftBukkitUpdatesCron : TcAdminCronJob
     {
         private BukkitSettings _bukkitSettings;
 
-        public MinecraftBukkitUpdatesCron() : base(Logger.Create<MinecraftBukkitUpdatesCron>())
+        public MinecraftBukkitUpdatesCron() : base()
         {
         }
 

Crons/GameUpdates/MinecraftPaperUpdatesCron.cs

@@ -13,7 +13,7 @@ public class MinecraftPaperUpdatesCron : TcAdminCronJob
     {
         private PaperSettings _paperSettings;
 
-        public MinecraftPaperUpdatesCron() : base(Logger.Create<MinecraftPaperUpdatesCron>())
+        public MinecraftPaperUpdatesCron() : base()
         {
         }
 

Crons/GameUpdates/MinecraftSpigotUpdatesCron.cs

@@ -11,7 +11,7 @@ public class MinecraftSpigotUpdatesCron : TcAdminCronJob
     {
         private SpigotSettings _spigotSettings;
 
-        public MinecraftSpigotUpdatesCron() : base(Alexr03.Common.Logging.Logger.Create<MinecraftSpigotUpdatesCron>())
+        public MinecraftSpigotUpdatesCron() : base()
         {
         }
 

Crons/GameUpdates/MinecraftVanillaSnapshotUpdatesCron.cs

@@ -11,7 +11,7 @@ public class MinecraftVanillaSnapshotUpdatesCron : TcAdminCronJob
     {
         private VanillaSnapshotSettings _vanillaSnapshotSettings;
 
-        public MinecraftVanillaSnapshotUpdatesCron() : base(Alexr03.Common.Logging.Logger.Create<MinecraftVanillaSnapshotUpdatesCron>())
+        public MinecraftVanillaSnapshotUpdatesCron() : base()
         {
         }
 

Crons/GameUpdates/MinecraftVanillaUpdatesCron.cs

@@ -15,7 +15,7 @@ public class MinecraftVanillaUpdatesCron : TcAdminCronJob
     {
         private VanillaSettings _vanillaSettings;
 
-        public MinecraftVanillaUpdatesCron() : base(Alexr03.Common.Logging.Logger.Create<MinecraftVanillaUpdatesCron>())
+        public MinecraftVanillaUpdatesCron() : base()
         {
         }
 

Globals.cs

@@ -3,5 +3,6 @@
     public static class Globals
     {
         public const string ModuleId = "3a0e1e17-cbee-4e00-871e-e3f492e8c8da";
+        public const string TableName = "tcmodule_cron_jobs";
     }
 }

Models/Objects/CronJob.cs

@@ -2,6 +2,8 @@
 using System.Linq;
 using Alexr03.Common.TCAdmin.Objects;
 using TCAdmin.Interfaces.Database;
+using TCAdmin.SDK.Objects;
+using TCAdmin.SDK.Web.MVC.Controllers;
 
 namespace TCAdminCrons.Models.Objects
 {
@@ -11,7 +13,7 @@ public CronJob() : base("tcmodule_cron_jobs")
         {
             this.SetValue("id", -1);
         }
-
+        
         public CronJob(int id) : this()
         {
             this.SetValue("id", id);

TcAdminCronJob.cs

@@ -5,12 +5,12 @@ namespace TCAdminCrons
 {
     public abstract class TcAdminCronJob : IJob
     {
-        protected TcAdminCronJob(Logger logger)
+        protected TcAdminCronJob()
         {
-            Logger = logger;
+            Logger = Logger.Create(GetType());
         }
 
-        public Logger Logger { get; private set; }
+        public Logger Logger { get; }
 
         public abstract System.Threading.Tasks.Task DoAction();
 

Views/TCAdminCrons.Controllers/Crons/Configuration.cshtml

@@ -15,7 +15,7 @@
     .Name("tabstrip")
     .Items(items =>
     {
-        foreach (var cronJob in CronJob.GetCronJobs().Where(cron => cron.Configuration.HasView()))
+        foreach (var cronJob in CronJob.GetCronJobs().Where(cron => cron.HasConfiguration && cron.Configuration.HasView()))
         {
             items.Add().Text(cronJob.Create().GetType().Name.SplitEveryCapital()).LoadContentFrom("ConfigureCron", "Crons", new {id = cronJob.Id});
         }