This repository has been archived by the owner on May 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Release 2.3.0 is broken on node@4.x #18
Comments
Please also see: https://travis-ci.org/TooTallNate/node-proxy-agent/builds/365266572 |
Please revert this change or at least mark the version to be 3.0.0 My production servers are breaking right now because of this. This is a breaking change and should not be included in a minor version bump! |
Damn, nice catch :( @ggoodman Can I give you push access to these |
Hi @TooTallNate, if you're ok with that and you find yourself in a bandwidth crunch, let's do it. Is there a way I can reach you when PRs are ready to merge / publish? I won't be able to deal with this until tomorrow morning (EDT). |
@ggoodman Ok added. Twitter DM should work, or ping me on https://zeit.chat |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@TooTallNate this change results in the new
socks-proxy-agent@4
being pulled in. The4.x
series ofsocks-proxy-agent
introduces anode>=6
constraint due to its reliance onsocks@2
(and probably other things) where newer syntax (function argument defaults) is introduced that is a syntax error onnode@4.x
.Would you consider releasing this as a new major considering this backwards incompatibility and re-releasing a
2.3.x
patch release reverting thesocks-proxy-agent
bump?How can I help expedite this?
The text was updated successfully, but these errors were encountered: