Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Release 2.3.0 is broken on node@4.x #18

Closed
ggoodman opened this issue Apr 11, 2018 · 5 comments
Closed

Release 2.3.0 is broken on node@4.x #18

ggoodman opened this issue Apr 11, 2018 · 5 comments

Comments

@ggoodman
Copy link
Collaborator

@TooTallNate this change results in the new socks-proxy-agent@4 being pulled in. The 4.x series of socks-proxy-agent introduces a node>=6 constraint due to its reliance on socks@2 (and probably other things) where newer syntax (function argument defaults) is introduced that is a syntax error on node@4.x.

Would you consider releasing this as a new major considering this backwards incompatibility and re-releasing a 2.3.x patch release reverting the socks-proxy-agent bump?

How can I help expedite this?

@ggoodman
Copy link
Collaborator Author

@liuzhen2008
Copy link

liuzhen2008 commented Apr 11, 2018

Please revert this change or at least mark the version to be 3.0.0

My production servers are breaking right now because of this.

This is a breaking change and should not be included in a minor version bump!

@TooTallNate
Copy link
Owner

Damn, nice catch :(

@ggoodman Can I give you push access to these -proxy-agent repos?

@ggoodman
Copy link
Collaborator Author

ggoodman commented Apr 11, 2018

Hi @TooTallNate, if you're ok with that and you find yourself in a bandwidth crunch, let's do it. Is there a way I can reach you when PRs are ready to merge / publish?

I won't be able to deal with this until tomorrow morning (EDT).

@TooTallNate
Copy link
Owner

@ggoodman Ok added. Twitter DM should work, or ping me on https://zeit.chat

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants