Make SSLSocketChannel2 handle multiple SSL messages in 1 buffer read #153
Conversation
… a single read from the socket (as was happening with my node server) then only the first one was being processed. Took 5 days to track this down.
|
thank you very much for finding and fixing this problem - i will merge SSLSocketChannel2 today. |
|
hm i overcomplicated things by pulling everythin and then rebasing. @2fours You will possibly have to force a pull... |
|
There seem to be problems on older android platforms because of this bug in SSLEngine : https://code.google.com/p/android/issues/detail?id=12955#c12. It appears that the only way this will work on these platforms is to abandon SSLEngine and use SSLSocket. Any chance of that happening? |
|
Do you mean that your code is working fine but there is a problem with what i merged? If there is a general probelm i would like to know the exact exeption or build error message and the android version you are working on. The solution suggested in #141 might solve the problem. |
|
The merged code is fine, the problem is the library will never work on Android versions < 3.0 (which is where the bug is fixed I believe) as long as it uses SSLEngine. #141 will not fix the issue. |
Took me a few days to track this bug down. On my node server the Server Hello, Certificate, and ServerHelloDone messages were being returned in one tcp packet. The code in SSLSocketChannel2 was only handling the first message in the packet, so the SSL handshake would never complete. Please ignore the other file changes, SSLSocketChannel2 is the only file you need to merge.
Thanks for the great library.
Adam