Skip to content

Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2022
Merged

Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer #1223

merged 8 commits into from
Mar 25, 2022

Conversation

@Serpion-ua
Copy link
Contributor

@Serpion-ua Serpion-ua commented Mar 24, 2022 •
edited by marci4
Loading

Added java.lang.Error handling in WebSocketImpl and WebSocketServer. Fatal Error ( VirtualMachineError | ThreadDeath | LinkageError ) lead to stopping of WebSocketServer. Now non-fatal Error leads to closing of web socket but not stopping of WebSocketServer.

Fixes #1160

Oleg Aleksandrov and others added 2 commits March 24, 2022 17:04
Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSoc…
d9537d6 
…ketServer
@Serpion-ua
Merge pull request #1 from Serpion-ua/Issue-1160
7700b91 
Issue-1160 Added java.lang.Error handling in WebSocketImpl and WebSocketServer
@Serpion-ua Serpion-ua mentioned this pull request Mar 24, 2022
Closed
@Marcono1234
Copy link

When wrapping the Error in an Exception it might be good to preserve its stack trace, e.g. by using new Exception(e) instead of new Exception(e.getMessage()).

Oleg Aleksandrov and others added 3 commits March 24, 2022 22:18
Issue-1160 Put whole Error into Exception during Error processing, no…
a2eeaaa 
…t just stack trace
@Serpion-ua
Merge pull request #2 from Serpion-ua/Issue-1160
e8ef74a 
Issue-1160 Put whole Error into Exception during Error processing, not just stack trace
Issue-1160 Add whole exception not just exception message when conver…
a97965d 
…ting Erro to Exception
@Serpion-ua
Copy link
Contributor Author

When wrapping the Error in an Exception it might be good to preserve its stack trace, e.g. by using new Exception(e) instead of new Exception(e.getMessage()).

@Marcono1234 yeap, changed

@marci4 marci4 requested a review from PhilipRoman March 25, 2022 06:21
PhilipRoman
PhilipRoman reviewed Mar 25, 2022
View reviewed changes
@marci4 marci4 added this to the Release 1.5.3 milestone Mar 25, 2022
@marci4
Copy link
Collaborator

marci4 commented Mar 25, 2022

@Serpion-ua thank you very much for your contribution!

@PhilipRoman thank you for your review!

@marci4 marci4 merged commit 46ae001 into TooTallNate:master Mar 25, 2022
@kashiro68 kashiro68 mentioned this pull request Feb 20, 2025
Open
@evoisard evoisard mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees

No one assigned

Labels

Bug Client Server

Projects

None yet

Milestone

Release 1.5.3

Development

Successfully merging this pull request may close these issues.

WebSocketWorker does not handle Throwable

5 participants

@Serpion-ua @Marcono1234 @marci4 @PhilipRoman @serpion