Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception with sending ping without server access #579

Closed
tiagosantos1988 opened this issue Oct 20, 2017 · 5 comments
Closed

Exception with sending ping without server access #579

tiagosantos1988 opened this issue Oct 20, 2017 · 5 comments
Labels
Bug Client missing-information
Milestone
Release 1.3.6

Comments

@tiagosantos1988
Copy link

There is a problem with sending ping. If there isn't server access it throws an exception. It didn't happend in version 1.3.4.
@tiagomartines11
Copy link

I believe the new version is failing to detect some disconnection state before dispatching internal commands.
These are some traces that are related to this issue:

Fatal Exception: org.java_websocket.exceptions.WebsocketNotConnectedException
--
  | org.java_websocket.WebSocketImpl.send (WebSocketImpl.java:608)
  | org.java_websocket.WebSocketImpl.sendFrame (WebSocketImpl.java:634)
  | org.java_websocket.WebSocketImpl.sendPing (WebSocketImpl.java:641)
  | org.java_websocket.AbstractWebSocket$1.run (AbstractWebSocket.java:132)

Fatal Exception: org.java_websocket.exceptions.WebsocketNotConnectedException
--
  | org.java_websocket.WebSocketImpl.send (WebSocketImpl.java:608)
  | org.java_websocket.WebSocketImpl.sendFrame (WebSocketImpl.java:634)
  | org.java_websocket.WebSocketImpl.close (WebSocketImpl.java:440)
  | org.java_websocket.WebSocketImpl.close (WebSocketImpl.java:569)
  | org.java_websocket.client.WebSocketClient.close (WebSocketClient.java:190)

@marci4
Copy link
Collaborator

marci4 commented Oct 21, 2017 •
edited
Loading

Please use the template provided for any bug report. It is there for a reason to help me understand the problems.

@tiagosantos1988
Copy link
Author

The problem I'm having is exactly that quoted by @tiagomartines11 .

@marci4
Copy link
Collaborator

marci4 commented Oct 24, 2017

With your poor description, it took me half an hour to reproduce your first issue with sendPing().

Without proper steps to repeat I cannot reproduce the second issue!

Greetings
marci4

marci4 added a commit to marci4/Java-WebSocket-Dev that referenced this issue Oct 24, 2017
@marci4
Connection lost timer should not start on setter call
7c34388 
Calling the setter starts the timer, which may cause a
WebsocketNotConnectedException (see TooTallNate#579)
@marci4 marci4 mentioned this issue Oct 24, 2017
Merged
8 tasks
@marci4 marci4 added this to the Release 1.3.6 milestone Oct 25, 2017
@marci4 marci4 mentioned this issue Nov 8, 2017
Closed
marci4 added a commit to marci4/Java-WebSocket-Dev that referenced this issue Nov 9, 2017
@marci4
Check for sending a close frame
7bc8fa1 
TooTallNate#579
@marci4 marci4 mentioned this issue Nov 9, 2017
Merged
8 tasks
@marci4
Copy link
Collaborator

marci4 commented Nov 9, 2017

Should be fixed with new version..

Closing issue!
Greetings
marci4

@marci4 marci4 closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Client missing-information
Projects
None yet
Milestone
Release 1.3.6
Development

No branches or pull requests
3 participants
@tiagomartines11 @tiagosantos1988 @marci4