Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTINUOUS should be decoded depending on the first frame #1230

Closed
marci4 opened this issue Apr 1, 2022 · 0 comments · Fixed by #1232
Closed

CONTINUOUS should be decoded depending on the first frame #1230

marci4 opened this issue Apr 1, 2022 · 0 comments · Fixed by #1232
Labels
Bug Client Server
Milestone
Release 1.5.3

Comments

@marci4
Copy link
Collaborator

marci4 commented Apr 1, 2022

Describe the bug
Due to changes with #1165 a return was introduced to handle not decode messages where no RSV1 is set.
This is however the case for a frame with opcode CONTINUOUS.
It is a valid framing and should therefore work

To Reproduce
Steps to reproduce the behavior:

  1. Run autobahn testsuite

Expected behavior
autoban testsuite passes
@marci4 marci4 added this to the Release 1.5.3 milestone Apr 1, 2022
@marci4 marci4 mentioned this issue Apr 1, 2022
Closed
12 tasks
marci4 added a commit to marci4/Java-WebSocket-Dev that referenced this issue Apr 3, 2022
@marci4
Fixes TooTallNate#1230 Adjust the handling of RSV1/RSV2/RSV3 in the t…
a4d23c3 
…ranslateSingleFrame
@marci4 marci4 mentioned this issue Apr 3, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Client Server
Projects
None yet
Milestone
Release 1.5.3
Development

Successfully merging a pull request may close this issue.

Adjust the handling of RSV1/RSV2/RSV3 in the translateSingleFrame marci4/Java-WebSocket-Dev
1 participant
@marci4