Less verbose unit types #1181
Merged
Less verbose unit types #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code004Accepted
approved these changes
Jun 18, 2023
|
This is awesome! super late reply, but great improvement |
tambien
added a commit
that referenced
this pull request
Apr 30, 2024
* Update test.yml * Update test.yml * Less verbose unit types (#1181) Co-authored-by: IntGrah <intgrah@gmail.com> * reverting isNote test, fixing workflow * fixing job dependencies * Deprecating singleton variables, use singleton getter instead (#1233) * Deprecating singleton variables, use singleton getter instead * updating references * moving over to getters instead of global vars * Simplifying oscillator type strings using templates (#1234) * simplifying interface types using templates * uploading codecov threshold * adjusting thresh * updating checkout * organizing docs (#1235) * Updating link syntax (#1236) * Using @see typedoc (#1237) * updating link to Context instead of BaseContext (#1238) * Update README.md * Small doc updates and tweaks (#1239) --------- Co-authored-by: IntGrah <intgrah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.Use template literal types
Use recursive conditional types for
type MidiNoteMakes it less verbose and doesn't take half the screen.