[ToggleManager] - Fix publishers being completed on override reset #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After calling
removeOverrides()ordelete()fromToggleManager, impactedToggleObservableelements would stop responding to subsequent value changes. Subscribers would receive completion events and become permanently inactive.Root Cause
The
removeOverrides()anddelete()methods were completing and removing allCurrentValueSubjectpublishers from the internalsubjectsRefsdictionary. This caused:Fix
I updated
ToggleManager.swiftandToggleManager+Overrides.swiftto preserve publisher lifecycle:Instead of completing and removing publishers, the methods now send new values (reverting to defaults) to existing subjects. Publishers remain active in
subjectsRefsand continue functioning after override removal.Subscribers remain subscribed and properly receive the new default values through the publisher.
Note
I also refactored the demo app
Observablestab to add interactive UI elements to testToggleObservableseasily.Attachments
ToggleDetailView, even after resetting overrides.