Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 32 vs 64-bit integer ambiguity #562

Closed
sgillies opened this issue Mar 24, 2018 · 0 comments
Closed

Fix for 32 vs 64-bit integer ambiguity #562

sgillies opened this issue Mar 24, 2018 · 0 comments
Labels
Milestone

Comments

@sgillies
Copy link
Member

sgillies commented Mar 24, 2018

This issue was reported in geopandas/geopandas#691 and probably also complicates PR #540 in some way.

@snorfalorpagus I think it's time to make 'int' in a Fiona schema mean 64-bit integer as in Python and Numpy.

>>> numpy.dtype('int')
dtype('int64')

and, instead of relying on integer field width, add a new 'int32' name here: https://github.com/Toblerity/Fiona/blob/master/fiona/ogrext.pyx#L48 for 32 bit-integers.

Fiona 1.8 will then fix that particular GeoPandas issue. We will not backport this to 1.7, where there is a field width workaround: int:18 for big ints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant