fix(vscode): filter go to definitions by position #4345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benfdking
commented
May 8, 2025
•
benfdking
commented
- before we were returning the references for a whole file
- now we filter by the position of the request
benfdking
force-pushed
the
fix_fix_returning_multiple_references
branch
from
59ff122 to
36ebdb0
Compare
benfdking
changed the title
benfdking
force-pushed
the
fix_fix_returning_multiple_references
branch
from
36ebdb0 to
268d423
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the VS Code go-to definitions functionality by filtering references based on the cursor position rather than returning all references in a file. Key changes include:
- Addition of a new function, filter_references_by_position, to narrow down the references.
- Unit tests in tests/lsp/test_reference.py to validate the position filtering behavior.
- Updates to the goto_definition function in sqlmesh/lsp/main.py to use the filtered references.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/lsp/test_reference.py | Added tests for the new filtering function and updated imports. |
| sqlmesh/lsp/reference.py | Introduced filter_references_by_position to filter references. |
| sqlmesh/lsp/main.py | Updated goto_definition to leverage the new filtering function. |
themisvaltinos
approved these changes
May 9, 2025
Used 'with' statement to properly close file handle after reading. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
benfdking
force-pushed
the
fix_fix_returning_multiple_references
branch
from
9d5168d to
c167676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.