-
Notifications
You must be signed in to change notification settings - Fork 207
Enable reload of modified models #4301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable reload of modified models #4301
Conversation
"I've read the description and the PR a few times, but I'm still a bit unclear on what this is fixing exactly. Could you share steps to reproduce the issue—or even better, a test case that fails without this fix? |
Hi @izeigerman The problem description is in #4250. For this to work the models' In the mean time I have made an attempted to figure out how to in fact load the models once more including the mutations, thereby updating the The (slightly contrived, I admit) example where the macro call I thought it could make sense to add a method So far I have only looked into how to do this for sql models, so python models and seeds are pending. And I might have missed a thing or two of course. So I was hoping you (or one of the other experts) could provide some feedback. If you think the outlined approach is sensible I'll be happy to have a go at adding pytests and so on. |
|
@sungchun12 this is the PR I mentioned in our meeting |
Suggestion for loading models from definitions instead of files which would be helpful in custom loaders.
Without reloading models after modifying them, custom loaders are more or less limited to using pure SQL in added or modified expressions.
This MR showcases a way to load models from their rendered definitions. The PR currently only adds support for sql models but I imagine support for python models and seed models can be added in a similar fashion.
I suppose support for python models, seed models plus a bunch of tests need to be added to make this PR proper but before proceeding with this I would appreciate some feedback. It wouldn't make sense to put more work into this if I'm completely on the wrong track.