Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining even if the meeting is blacklisted #48

Open
ntaraujo opened this issue Nov 6, 2020 · 6 comments
Open

Joining even if the meeting is blacklisted #48

ntaraujo opened this issue Nov 6, 2020 · 6 comments

Comments

@ntaraujo
Copy link

ntaraujo commented Nov 6, 2020

I had a class I didn't want to join, because its optional (support class), so I left "blacklist_meeting_re" set in config.json with a regex syntax that looks like right.

But auto_joiner.py tried to join in that class even confirming it was [BLACKLISTED]

Screenshot
joiner
The print didn't catch the end of that line, but its written

Plantão de Física 2 EMC from 9:30 AM to 10:20 AM 1604665800 [Calendar] [BLACKLISTED]

And after Wating for 23s

Configuration file

{
 "email": "*****",
 "password": "********",

 "run_at_time": "",

 "meeting_mode": 1,
 "organisation_num" : 1,
 "random_delay": true,
 "check_interval": 10,

 "auto_leave_after_min": 60,
 "leave_if_last": true,

 "headless" : false,
 "mute_audio": true,
 "chrome_type": "google-chrome",

 "blacklist": [
   {
     "team_name": "Example Team 1",
     "channel_names": [
       "First Channel to blacklist in this team",
       "Second Channel to blacklist"
     ]
   },
    {
     "team_name": "Blacklist whole team",
     "channel_names": [
     ]
   }
 ],
 "blacklist_meeting_re": "(?i)^(plantão|apoio)"
}

(?i)^(plantão|apoio) catch both expressions (Brazillian Portuguese) with or without capital letters.
I put it after some research and testing, should be right even why the [BLACKLISTED] flag appears.

Desktop

  • OS: Zorin OS 15.3 (Ubuntu 18.04.1 LTS)
  • Browser: google-chrome
  • Version: 86.0.4240.183 (Official Build) (64-bit)

Additional context
I made some changes to specific needs:

  • in check_blacklist() to let only one team not to be blacklisted
  • in windows resizer to a bigger size
  • in auto_leave_after_min feature to take into account double classes
  • in try: main(), adding an except to end the program without errors if the browser is closed

This is probably not the reason for the bug

Why does it happen? Did i do something wrong? Could it be the fact that the meeting is appearing as "Meeting now" instead of "Plantão de Física 2 EMC"?

Thanks in advance

@ntaraujo
Copy link
Author

Any help?

@TobiasPankner
Copy link
Owner

I've looked into it and cannot seem to find the issue, can you please try with a fresh install of the bot to verify it's not the changes you've made?

@ntaraujo
Copy link
Author

Thanks for answering

I did what you said with the same config.json. Also made a testing channel called "Teste" and scheduled a meeting called "Plantão de alguma coisa", which i entered in another browser

Same results bro

The bot tried to enter the meeting even after printing "[BLACKLISTED]"

Screenshot from 2020-11-15 15-37-39

@TobiasPankner
Copy link
Owner

In the screenshot you attached the meeting in the "Teste" channel is not blacklisted but the other one is. Which one did the bot try to join?

@ntaraujo
Copy link
Author

Oops, "Teste" is not a channel, is a team.
I created a team called "Teste" and schedulled a meeting in the "General" channel. This meeting I called "Plantão de alguma coisa"
The channel is the same one that is marked with "[MEETING]" up there

and, omg... I thought that line with "Teste -> General" was just to tell which channel and team the meeting was found on

Is the bot finding the meeting under another name when searching the channels?

There was only one meeting going on at the moment, and by the names, those two are the same

@ntaraujo
Copy link
Author

I just retake the test with meeting_mode as 2 and 3

Screenshot from 2020-11-15 20-20-33
with meeting_mode as 3, it just keep looking in calendar

Screenshot from 2020-11-15 20-21-43
with meeting_mode as 2, yes, that happens again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants