Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on line tracing routine #871

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

Conversation

adriendaros
Copy link
Collaborator

Aim :

Modifications on the routine tofu/geom/plot_line_on_det_tracing() have been made in order to integrate multiple lines tracing at the same time, in order to simulate a 2D spectra (w/o line intensities, only positions).

Main changes:

  • Wavelengths dictionnary are available by default, containing the main lines of interest for ArXVII spectra measured w/ the XICS spectrometer on WEST.
    Are available:
  1. lamb = 'ArXVII' w/ ArXVII (w,x,y,z), ArXVI (q,r,a,k,j), ArXV (n=3), WXLIV and WXLIII lines
  2. lamb = 'ArXVII-woW' w/ ArXVII (w,x,y,z), ArXVI (q,r,a,k,j) and ArXV (n=3) lines
  3. lamb = 'ArXVII-wxyz' w/ ArXVII (w,x,y,z) lines
  4. By default, lamb = None take the wavelength of reference of the crystal used
  • Possibility to choose the number of points characterizing a line in the vertical scale by the argument phi (by default to 100)
  • Possibility to change the x- and y-scale for pixels coordinates from the origin at the center of the camera to an origin at the left low corner -> mode = 'raw det'
  • Computation of a simulated 2D spectra from the lines traced + the traces of the Rocking Curve computed for the specified wavelength -> merge_rc_data = True + plot_simu_image = True

Examples:

image
image
image


image
image
image


image
image
image
image

AD265925 added 2 commits November 8, 2023 11:05
…nge pixels coords to lower origin, can convert line+Rcs traces on detector to 2D image
…wavelength, add if already exists name of wavelength (dlamb dict)
@pep8speaks
Copy link

pep8speaks commented Nov 8, 2023

Hello @adriendaros! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2510:80: E501 line too long (80 > 79 characters)
Line 2573:80: E501 line too long (80 > 79 characters)
Line 2699:13: E265 block comment should start with '# '
Line 3307:39: E262 inline comment should start with '# '

Line 1078:80: E501 line too long (88 > 79 characters)
Line 1087:80: E501 line too long (83 > 79 characters)
Line 1124:80: E501 line too long (81 > 79 characters)

Line 1511:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-01-17 08:41:59 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants