Skip to content

Conversation

@shaneahmed
Copy link
Member

@shaneahmed shaneahmed commented Jun 30, 2023

  • Fix dictionary changed size error in 08-nucleus-instance-segmentation and 09-multi-task-segmentation
  • Changing num_loader_workers=0 and num_postproc_workers=0 fixes the error on Colab.
  • 09-multi-task-segmentation fails to load tmp\sample_tile_results\0.raw.0.npy still fails which is not saved.

- Fix `dictionary changed size` error in 08-nucleus-instance-segmentation and 09-multi-task-segmentation
- Changing num_loader_workers=0 and num_postproc_workers=0 fixes the error on Colab.
@shaneahmed shaneahmed added this to the Release v1.4.1 milestone Jun 30, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shaneahmed
Copy link
Member Author

09-multi-task-segmentation fails to load tmp\sample_tile_results\0.raw.0.npy still fails which is not saved.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #626 (33dcc66) into develop (7c4840c) will not change coverage.
The diff coverage is n/a.

❗ Current head 33dcc66 differs from pull request most recent head 14f6bd8. Consider uploading reports for the commit 14f6bd8 to get more accurate results

@@           Coverage Diff            @@
##           develop     #626   +/-   ##
========================================
  Coverage    99.84%   99.84%           
========================================
  Files           64       64           
  Lines         7305     7305           
  Branches      1405     1405           
========================================
  Hits          7294     7294           
  Misses           4        4           
  Partials         7        7           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed shaneahmed added the documentation Improvements or additions to documentation label Jun 30, 2023
@shaneahmed shaneahmed self-assigned this Jun 30, 2023
@John-P
Copy link
Contributor

John-P commented Jul 14, 2023

I noticed that you have set the worker subprocesses to 0 in the notebooks. However, is this really addressing the root cause of the issue? I believe we should be able to use more workers in the notebooks. Is this just a temporary solution?

@shaneahmed shaneahmed requested a review from adamshephard July 14, 2023 09:52
@shaneahmed
Copy link
Member Author

I noticed that you have set the worker subprocesses to 0 in the notebooks. However, is this really addressing the root cause of the issue? I believe we should be able to use more workers in the notebooks. Is this just a temporary solution?

I have tested this locally with multiple Python versions on Windows and Ubuntu with num_workers=4, 16 and it works fine. Something failing with multiprocessing on Colab.

@shaneahmed shaneahmed changed the title 🐛 Fix dictionary changed size error 🐛 Fix dictionary changed size Error Jul 24, 2023
shaneahmed and others added 7 commits July 24, 2023 23:38
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
… into bug-fix-dictionary-resize-error

# Conflicts:
#	examples/09-multi-task-segmentation.ipynb
@shaneahmed shaneahmed merged commit c067927 into develop Jul 25, 2023
@shaneahmed shaneahmed deleted the bug-fix-dictionary-resize-error branch July 25, 2023 10:44
@shaneahmed shaneahmed mentioned this pull request Jul 25, 2023
shaneahmed added a commit that referenced this pull request Jul 25, 2023
### Bug Fixes and Other Changes

- Fix dictionary changed size Error #626 (#605)
shaneahmed added a commit that referenced this pull request Jul 25, 2023
- ### Bug Fixes and Other Changes

- Fix dictionary changed size Error #626 (#605)

Full Changelog: v1.4.0...v1.4.1

Signed-off-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
@shaneahmed shaneahmed mentioned this pull request Jul 25, 2023
shaneahmed added a commit that referenced this pull request Jul 25, 2023
- ### Bug Fixes and Other Changes

  - Fix dictionary changed size Error #626 (#605)

Full Changelog: v1.4.0...v1.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Segmentation engines produce dictionary changed size during iteration error

4 participants