Fix reciprocal polarization energy with PME #33
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reciprocal polarization energy was missing the Coulomb constant, which is fixed by this patch. I added the factor as
electric / dielec
, but I noticed that many places, like this, onlyelectric
is used.I also had to roll back this change or the code gets stuck in an infinite loop on my laptop (macOS 10.12, gfortran 7.1).