Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for timely TimelyDataflow/timely-dataflow#569 #511

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jun 7, 2024

This fixes a potential bug in the consolidating container builder where it
would not clear buffers that were exposed to the user. There is no
obligation for the user to call clear, so call it when recycling.

Signed-off-by: Moritz Hoffmann antiguru@gmail.com

@antiguru antiguru marked this pull request as draft June 7, 2024 18:10
@antiguru antiguru changed the title Adjust for timely #569 Adjust for timely https://github.com/TimelyDataflow/timely-dataflow/pull/569 Jun 7, 2024
@antiguru antiguru changed the title Adjust for timely https://github.com/TimelyDataflow/timely-dataflow/pull/569 Adjust for timely TimelyDataflow/timely-dataflow#569 Jun 7, 2024
@antiguru antiguru marked this pull request as ready for review June 13, 2024 01:30
@@ -155,25 +155,25 @@ where
let mut drain = self.current.drain(..(self.current.len()/multiple)*multiple).peekable();
while drain.peek().is_some() {
let mut container = self.empty.pop().unwrap_or_else(|| Vec::with_capacity(preferred_capacity));
container.clear();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a where we would retain data if the user didn't clear the container.

This fixes a potential bug in the consolidating container builder where it
would not clear buffers that were exposed to the user. There is no
obligation for the user to call clear, so call it when recycling.

Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@antiguru
Copy link
Member Author

@frankmcsherry seems ok with it, so merging!

@antiguru antiguru merged commit 7c4eec9 into TimelyDataflow:master Jun 13, 2024
7 checks passed
@antiguru antiguru deleted the timely_569 branch June 13, 2024 15:36
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant