This repository was archived by the owner on Oct 6, 2025. It is now read-only.
feat: introduce fairness #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceo
commented
Jun 26, 2024
triceo
commented
Jun 26, 2024
timefold-solver-python-core/src/main/python/score/_constraint_stream.py
Outdated
Show resolved
Hide resolved
triceo
commented
Jun 26, 2024
timefold-solver-python-core/src/main/python/score/_constraint_stream.py
Outdated
Show resolved
Hide resolved
triceo
commented
Jun 27, 2024
triceo
commented
Jun 27, 2024
triceo
commented
Jun 27, 2024
triceo
commented
Jun 27, 2024
Christopher-Chianelli
suggested changes
Jul 3, 2024
Collaborator
Christopher-Chianelli
left a comment
Christopher-Chianelli
left a comment
There was a problem hiding this comment.
Please add tests for load_balance.
triceo
commented
Jul 3, 2024
Christopher-Chianelli
suggested changes
Jul 8, 2024
Collaborator
Christopher-Chianelli
left a comment
Christopher-Chianelli
left a comment
There was a problem hiding this comment.
Missing tests for new verifier methods; other than that, LGTM
|
Christopher-Chianelli
approved these changes
Jul 8, 2024
Collaborator
Christopher-Chianelli
left a comment
Christopher-Chianelli
left a comment
There was a problem hiding this comment.
load_balance would need to become more Pythonic, but that depends on the Decimal type + consecutive_sequences also needs a rework. LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.