Add new voice configuration for nl-NL Alex in piper.json#116
Add new voice configuration for nl-NL Alex in piper.json#116timonvanhasselt wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughA new Dutch (nl_NL) Piper voice entry for "alex-medium" was added to the voice index configuration file with metadata including voice ID, model URL, phoneme type, and remote resource URLs. File formatting was adjusted with a proper trailing newline. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
phoonnx/voice_index/piper.json (1)
1497-1509: Fix indentation: key should start at 4 spaces, not 8.The new entry has inconsistent indentation compared to existing entries like
piper/nl_NL-ronnie-medium(line 1484). The key should be indented at 4 spaces with properties at 8 spaces; currently both the key and properties are at 8 spaces. While the JSON is syntactically valid, this creates inconsistent formatting across the file.Both referenced files are accessible: the model file returns a 302 redirect and the config file returns a 307 redirect.
🔧 Proposed formatting fix
}, - "piper/nl_NL-alex-medium": { - "voice_id": "piper/nl_NL-alex-medium", - "model_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx", - "phoneme_type": "espeak", - "lang": "nl-NL", - "tokens_url": null, - "tokenizer_config_url": null, - "vocab_url": null, - "phoneme_map_url": null, - "alphabet": "ipa", - "engine": "piper", - "config_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx.json" + "piper/nl_NL-alex-medium": { + "voice_id": "piper/nl_NL-alex-medium", + "model_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx", + "phoneme_type": "espeak", + "lang": "nl-NL", + "tokens_url": null, + "tokenizer_config_url": null, + "vocab_url": null, + "phoneme_map_url": null, + "alphabet": "ipa", + "engine": "piper", + "config_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx.json" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@phoonnx/voice_index/piper.json` around lines 1497 - 1509, The JSON entry for "piper/nl_NL-alex-medium" is indented inconsistently (key and properties at 8 spaces) compared to other entries like "piper/nl_NL-ronnie-medium"; fix it by moving the key "piper/nl_NL-alex-medium" left to start at 4 spaces and ensure all its property lines (voice_id, model_url, phoneme_type, lang, tokens_url, tokenizer_config_url, vocab_url, phoneme_map_url, alphabet, engine, config_url) remain at 8 spaces so formatting matches the surrounding entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@phoonnx/voice_index/piper.json`:
- Around line 1497-1509: The JSON entry for "piper/nl_NL-alex-medium" is
indented inconsistently (key and properties at 8 spaces) compared to other
entries like "piper/nl_NL-ronnie-medium"; fix it by moving the key
"piper/nl_NL-alex-medium" left to start at 4 spaces and ensure all its property
lines (voice_id, model_url, phoneme_type, lang, tokens_url,
tokenizer_config_url, vocab_url, phoneme_map_url, alphabet, engine, config_url)
remain at 8 spaces so formatting matches the surrounding entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 377f6281-0554-4300-86ef-e81049b93910
📒 Files selected for processing (1)
phoonnx/voice_index/piper.json
Summary by CodeRabbit