Skip to content

Add new voice configuration for nl-NL Alex in piper.json#116

Open
timonvanhasselt wants to merge 1 commit into
TigreGotico:devfrom
timonvanhasselt:patch-3
Open

Add new voice configuration for nl-NL Alex in piper.json#116
timonvanhasselt wants to merge 1 commit into
TigreGotico:devfrom
timonvanhasselt:patch-3

Conversation

@timonvanhasselt
Copy link
Copy Markdown
Contributor

@timonvanhasselt timonvanhasselt commented Mar 31, 2026

Summary by CodeRabbit

  • New Features
    • Added support for Dutch language voice synthesis with a new voice option.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

A new Dutch (nl_NL) Piper voice entry for "alex-medium" was added to the voice index configuration file with metadata including voice ID, model URL, phoneme type, and remote resource URLs. File formatting was adjusted with a proper trailing newline.

Changes

Cohort / File(s) Summary
Voice Index Configuration
phoonnx/voice_index/piper.json
Added new voice entry piper/nl_NL-alex-medium with voice metadata (voice_id, model_url, phoneme_type, lang, config_url, and null URL references for tokens/tokenizer/vocab/phoneme_map). Applied trailing newline formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

feature

Poem

🐰 A Dutch voice joins the chorus bright,
Alex speaks in medium delight,
From nl_NL to your ears,
New linguistic frontiers!
Hoppy configuration, perfectly right! 🇳🇱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically describes the main change: adding a new voice configuration for the Dutch (nl-NL) Alex voice in piper.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
phoonnx/voice_index/piper.json (1)

1497-1509: Fix indentation: key should start at 4 spaces, not 8.

The new entry has inconsistent indentation compared to existing entries like piper/nl_NL-ronnie-medium (line 1484). The key should be indented at 4 spaces with properties at 8 spaces; currently both the key and properties are at 8 spaces. While the JSON is syntactically valid, this creates inconsistent formatting across the file.

Both referenced files are accessible: the model file returns a 302 redirect and the config file returns a 307 redirect.

🔧 Proposed formatting fix
     },
-        "piper/nl_NL-alex-medium": {
-        "voice_id": "piper/nl_NL-alex-medium",
-        "model_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx",
-        "phoneme_type": "espeak",
-        "lang": "nl-NL",
-        "tokens_url": null,
-        "tokenizer_config_url": null,
-        "vocab_url": null,
-        "phoneme_map_url": null,
-        "alphabet": "ipa",
-        "engine": "piper",
-        "config_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx.json"
+    "piper/nl_NL-alex-medium": {
+        "voice_id": "piper/nl_NL-alex-medium",
+        "model_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx",
+        "phoneme_type": "espeak",
+        "lang": "nl-NL",
+        "tokens_url": null,
+        "tokenizer_config_url": null,
+        "vocab_url": null,
+        "phoneme_map_url": null,
+        "alphabet": "ipa",
+        "engine": "piper",
+        "config_url": "https://huggingface.co/rhasspy/piper-voices/resolve/main/nl/nl_NL/alex/medium/nl_NL-alex-medium.onnx.json"
     },
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@phoonnx/voice_index/piper.json` around lines 1497 - 1509, The JSON entry for
"piper/nl_NL-alex-medium" is indented inconsistently (key and properties at 8
spaces) compared to other entries like "piper/nl_NL-ronnie-medium"; fix it by
moving the key "piper/nl_NL-alex-medium" left to start at 4 spaces and ensure
all its property lines (voice_id, model_url, phoneme_type, lang, tokens_url,
tokenizer_config_url, vocab_url, phoneme_map_url, alphabet, engine, config_url)
remain at 8 spaces so formatting matches the surrounding entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@phoonnx/voice_index/piper.json`:
- Around line 1497-1509: The JSON entry for "piper/nl_NL-alex-medium" is
indented inconsistently (key and properties at 8 spaces) compared to other
entries like "piper/nl_NL-ronnie-medium"; fix it by moving the key
"piper/nl_NL-alex-medium" left to start at 4 spaces and ensure all its property
lines (voice_id, model_url, phoneme_type, lang, tokens_url,
tokenizer_config_url, vocab_url, phoneme_map_url, alphabet, engine, config_url)
remain at 8 spaces so formatting matches the surrounding entries.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 377f6281-0554-4300-86ef-e81049b93910

📥 Commits

Reviewing files that changed from the base of the PR and between b5e5471 and 2de23cb.

📒 Files selected for processing (1)
  • phoonnx/voice_index/piper.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant