Skip to content

Commit eb36464

Browse files
restored Serial.begin(speed) to earlier version so blinkVersion is called at correct time
1 parent 12d5203 commit eb36464

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Firmata.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,18 @@ void FirmataClass::begin(void)
6767
void FirmataClass::begin(long speed)
6868
{
6969
Serial.begin(speed);
70-
begin(Serial);
71-
blinkVersion();
70+
FirmataSerial = &Serial;
71+
blinkVersion();
72+
printVersion();
73+
printFirmwareVersion();
7274
}
7375

7476
/* begin method for overriding default stream */
7577
void FirmataClass::begin(Stream &s)
7678
{
7779
FirmataSerial = &s;
80+
// do not call blinkVersion() here because some hardware such as the
81+
// Ethernet shield use pin 13
7882
printVersion();
7983
printFirmwareVersion();
8084
}

0 commit comments

Comments
 (0)