Skip to content

Updates pg to v8.0.3 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

maximilian-krauss
Copy link

Major version bump from pg to v8.0.3. Creates compatibility to node 14

✅ Unit and integration tests are passing 🙂

Fixes #42

@ThomWright
Copy link
Owner

I've just noticed that @types/pg doesn't have a v8 yet. Ideally I like the TS types for 8 published before upgrading to it. I know it's a pain, but I don't like having the TS types out of sync.

@maximilian-krauss
Copy link
Author

Oh, didn't notice you installed the types as well. Makes totally sense. I hope they will bump the types too...

@JCMais
Copy link

JCMais commented Jun 16, 2020

@ThomWright while there is no v8 version for @types/pg, the only required change to be made to the typing that I see from looking at pg's changelog was already done, which is typing the ssl option as boolean | tls.ConnectionOptions. Here is the related change: DefinitelyTyped/DefinitelyTyped#40728

@aimee-gm
Copy link

aimee-gm commented Aug 8, 2020

Could we consider merging this now?

@JCMais
Copy link

JCMais commented Aug 8, 2020

For anyone that do not want for a new release, you can force the pg version used by postgres-migrations with Yarn resolutions:

  "resolutions": {
    "**/postgres-migrations/pg": "^8.3.0"
  }

@ThomWright
Copy link
Owner

@ThomWright while there is no v8 version for @types/pg, the only required change to be made to the typing that I see from looking at pg's changelog was already done, which is typing the ssl option as boolean | tls.ConnectionOptions. Here is the related change: DefinitelyTyped/DefinitelyTyped#40728

Interesting. I vaguely remember trying to upgrade to pg@8 (outside of this library) and seeing type errors at runtime after successful compilation. I can't remember any more details though, so I might have to re-investigate.

As far as I can tell the linked changes in pg@8.1.0 don't make it any less of a breaking change. They simply make it easier to 'fix' the breakage as an application user with an environment variable. I think it will still result in a major version change for this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed version of pg client is not compatible with node 14
4 participants