Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax pnpm requirements #1284

Closed
tordans opened this issue Aug 31, 2024 · 2 comments
Closed

Relax pnpm requirements #1284

tordans opened this issue Aug 31, 2024 · 2 comments

Comments

@tordans
Copy link
Contributor

tordans commented Aug 31, 2024

Right now, I have to install a very specific minor version of pnpm in order to run keystatic for development.

% pnpm install
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your pnpm version is incompatible with "/Users/fmc/Development/NPM/keystatic".

Expected version: 8.15.4
Got: 8.15.9

This is happening because the package's manifest has an engines.pnpm field specified.
To fix this issue, install the required pnpm version globally.

To install the latest version of pnpm, run "pnpm i -g pnpm".
To check your pnpm version, run "pnpm -v".

I wonder, if it is possible to relax this to use any 8.15.* or maybe even update to the current 9.* branch.

@emmatown
Copy link
Member

emmatown commented Sep 5, 2024

The strict pnpm version is intentional so that different contributors don't use different versions of pnpm that create different lock files, like the README says it's recommended to use corepack

@emmatown emmatown closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@tordans
Copy link
Contributor Author

tordans commented Sep 6, 2024

Hi Emma!
On patch versions: I was under the assumption that a patch version does not include any breaking changes in how a lock file is generated or how pnpm works in general. But I don't know pnpm really…

On corepack: The meta feedback here is, that I don't understand what that means and what to do with this short sentence from the README. So the broader question is, how high of a barrier of entry you want to have for the project. Right now, I am blocked by looking into any possible contribution because I cannot even get it running and the research required to learn the details of different pnpm setups is too high…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants