-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/markdownify #56
base: master
Are you sure you want to change the base?
Conversation
cool addition. could you please update the function to include the following so it can be integrated into the package
example roxygen2 header#' @title Imager
#'
#' @description Convert the selected path into an embedded image
#'
#'
#' @return a markdown image link
#' @export
#' @importFrom rstudioapi getSourceEditorContext modifyRange
#'
#' @examples
#' \dontrun{
#' remedy_example(
#' c( "https://thinkr.fr/wp-content/uploads/2015/03/thinkR1.png"),
#' imager
#' )
#' }
imager <- function() {
|
Very good idea indeed. I have a more or less fully functional regex here : https://github.com/ColinFay/backyard/blob/master/R/html_to_markdown.R We can mix your PR and the code from there so to include more html tags. |
@yonicd cheers, can do. By 'update the binding field' do you mean because it should be @ColinFay neat! I was torn between bulk-processing of source and piecewise. I went with the latter as I tend to have embedded tweets and I don't think I want to convert that HTML. I currently have this set to only performing one conversion at a time, but perhaps reformatting a bulk section of text makes sense (with a warning about trying to do too much). I'll iterate. |
yes. the binding field needs to be the function name (that's being updated with trailing those hotkeys are good, it's a problem with so many to find one that makes sense and isnt in use. all the hotkeys in opts are mac centric, please dont mix with winOS. thanks again |
I'm not sure I could even test on windows... ugh. I'm coming from linux. |
If applied, this commit will introduce the
markdownify()
addin which converts HTML to markdown syntax. Refer to changes inREADME
for examples.Why is this change being made? I'm migrating my blog and want to update these HTML tags into native markdown. I realised it was a a fairly straightforward regex operation but wanted to formalise it into a package. I haven't seen this functionality elsewhere, but that doesn't preclude that from being the case.