chore: bump better-sqlite3-multiple-ciphers to 12.2.0 for Electron 37 #761
Conversation
WalkthroughUpdated two dependency versions in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
182-197: Pnpm build-script policy may slow CI or mask prebuild availability for this versionYou’ve configured pnpm to:
- build only a whitelist (onlyBuiltDependencies), and
- explicitly ignore better-sqlite3-multiple-ciphers install scripts (ignoredBuiltDependencies).
That guarantees no prebuilt binaries are downloaded even if 12.2.0 provides Electron 37 prebuilds, pushing all the work to electron-builder’s rebuild step. If CI time matters or you prefer using upstream prebuilds when available, consider allowing this package’s install script to run.
Option A (prefer prebuilds when available):
"pnpm": { "onlyBuiltDependencies": [ "@tailwindcss/oxide", "electron", "electron-winstaller", "lzo", - "simple-git-hooks" + "simple-git-hooks", + "better-sqlite3-multiple-ciphers" ], "ignoredBuiltDependencies": [ - "better-sqlite3-multiple-ciphers", "esbuild", "maplibre-gl", "sharp", "vue-demi" ] }Option B (keep current policy): add a brief doc note in CONTRIBUTING.md indicating that native binaries are produced by electron-builder install-app-deps, and that pnpm intentionally skips prebuild downloads for this dependency to ensure a consistent rebuild against the target Electron ABI.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
70-70: Action Required: Ensure a Python runtime is available and rerun native‐addon smoke testsIt looks like the install step is failing on another native dependency (lzo) due to a missing Python installation, so the smoke tests for better-sqlite3-multiple-ciphers never ran. Please:
- Install Python (≥2.7 or 3.x) in your build environment so that all native modules (including lzo) can compile successfully.
- Rerun the smoke-test script to verify that better-sqlite3-multiple-ciphers@12.2.0:
- Rebuilds correctly under Electron 37 (
electron-builder install-app-deps --force).- Loads and performs a simple query in plain Node.
- Loads and performs a simple query in the Electron main process.
Once you have the full success output for all three steps, please share it here to confirm compatibility.
Summary by CodeRabbit