fix(agent): fix inconsistent fc call record format in chained non-native function calling

[neoragex2002]

fix(agent): fix inconsistent fc call record format in chained non-native function calling

by: #514

Summary by CodeRabbit

• Bug Fixes

  • Improved handling and display of tool call results and errors in conversations, ensuring accurate updates in the UI and database.
  • Enhanced error messaging and structured prompts to maintain conversation flow after tool execution issues.

• Refactor

  • Streamlined internal logic for generating unique IDs for function calls, improving consistency and reliability.

• Style

  • Added clarifying comments and reorganized code for better readability and maintainability.

[coderabbitai]

Walkthrough

The updates focus on refining how tool call results and errors are handled in the agent loop of the LLMProviderPresenter class, ensuring structured events are yielded for UI/database updates. Additionally, the unique ID generation logic for function calls in the OpenAI-compatible provider is adjusted for more consistent fallback behavior.

Changes

File(s)	Change Summary
src/main/presenter/llmProviderPresenter/index.ts	Enhanced tool call result/error handling in startStreamCompletion; yields structured 'response' events with detailed metadata for UI/DB; reorganized message updates and added clarifying comments.
src/main/presenter/llmProviderPresenter/providers/openAICompatibleProvider.ts	Modified fallback logic for generating unique IDs in parseFunctionCalls to prioritize composite string IDs with function name and index over plain function name alone.

Poem

In the warren of code, new signals appear,
Tool calls and errors now crystal clear.
IDs are crafted with thoughtful care,
So every function finds its rightful lair.
The UI and DB will hop with delight—
Structured events guide them through the night!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c1ce9a and d6c168c.

📒 Files selected for processing (2)

• src/main/presenter/llmProviderPresenter/index.ts (3 hunks)
• src/main/presenter/llmProviderPresenter/providers/openAICompatibleProvider.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• src/main/presenter/llmProviderPresenter/providers/openAICompatibleProvider.ts
• src/main/presenter/llmProviderPresenter/index.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-check (x64)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

src/main/presenter/llmProviderPresenter/index.ts (2)

700-748: Risk of prompt bloat for non-native function-call chains

formattedToolResultText serialises the entire tool response into the assistant message that is fed back to the LLM.
Large payloads (e.g. long JSON / HTML) quickly exhaust contextLength, drastically increasing cost and truncation risk.

Consider:

• Truncating or summarising long responses before injection.
• Storing the raw result server-side and inserting only a short reference token.

This keeps the conversational context lean and predictable.

---

770-793: Redundant shadowing & boilerplate in error branch

const supportsFunctionCallInAgent = modelConfig?.functionCall || false; shadows the earlier supportsFunctionCall declared at line 494 and adds identical logic. Remove the duplicate or rename for clarity.

Additionally, native/non-native error handling blocks are nearly identical except for a couple of fields – extract a helper to DRY this section.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cff1cab and 0c1ce9a.

📒 Files selected for processing (2)

• src/main/presenter/llmProviderPresenter/index.ts (3 hunks)
• src/main/presenter/llmProviderPresenter/providers/openAICompatibleProvider.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build-check (x64)

[zerob13]

LGTM