fix(settings): await stored models retrieval from provider

[hllshiro]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of provider model initialization to ensure proper loading of model configurations.

[coderabbitai]

Walkthrough

A single async/await fix applied to the refreshStandardModels function. The retrieval of provider models was changed from a non-awaited call to a properly awaited asynchronous call, ensuring the promise resolves before proceeding with dependent logic.

Changes

Cohort / File(s)	Change Summary
Async/await fix src/renderer/src/stores/settings.ts	Added await keyword to configP.getProviderModels(providerId) call to properly resolve the promise before processing stored models

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Single line change (adding await keyword)
• No exported signatures modified
• Straightforward async/await correctness fix

Possibly related PRs

• fix: merge stored provider models when refreshing settings #1051: Also modifies refreshStandardModels to handle provider models retrieval and normalization in the same settings file.

Suggested labels

codex

Poem

🐰 A promise made, but left on wait,
Now properly awaited—no more late!
The models fetch without delay,
Async/await saves the day! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "fix(settings): await stored models retrieval from provider" directly and accurately describes the main change in the changeset. The modification in src/renderer/src/stores/settings.ts involves adding await to the getProviderModels(providerId) call in the refreshStandardModels function, which is precisely what the title conveys. The title is concise, specific, and uses clear language that a teammate reviewing the git history would immediately understand—it identifies both the action taken (adding await) and the context (retrieving stored models from a provider).

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7a8d06 and 1fa64b9.

📒 Files selected for processing (1)

• src/renderer/src/stores/settings.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (16)

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development-setup.mdc)

**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写

Files:

• src/renderer/src/stores/settings.ts

src/{main,renderer}/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)

src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/error-logging.mdc)

**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪（如适用）、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/**/*

📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/pinia-best-practices.mdc)

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}: Use modules to organize related state and actions
Implement proper state persistence for maintaining data across sessions
Use getters for computed state properties
Utilize actions for side effects and asynchronous operations
Keep the store focused on global state, not component-specific data

Files:

• src/renderer/src/stores/settings.ts

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

• src/renderer/src/stores/settings.ts

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

• src/renderer/src/stores/settings.ts

src/renderer/**/*.{vue,ts}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

• src/renderer/src/stores/settings.ts

src/renderer/**/*.{ts,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Use Pinia for frontend state management (do not introduce alternative state libraries)

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use English for all logs and comments

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Enable and adhere to strict TypeScript typing (avoid implicit any, prefer precise types)

Use PascalCase for TypeScript types and classes

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/**

📄 CodeRabbit inference engine (AGENTS.md)

Place Vue 3 app source under src/renderer/src (components, stores, views, i18n, lib)

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/**/*.{vue,ts}

📄 CodeRabbit inference engine (AGENTS.md)

All user-facing strings must use vue-i18n ($t/keys) rather than hardcoded literals

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,jsx,vue,css,scss,md,json,yml,yaml}

📄 CodeRabbit inference engine (AGENTS.md)

Prettier style: single quotes, no semicolons, print width 100; run pnpm run format

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,vue}: Use OxLint for JS/TS code; keep lint clean
Use camelCase for variables and functions
Use SCREAMING_SNAKE_CASE for constants

Files:

• src/renderer/src/stores/settings.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-check (x64)

🔇 Additional comments (1)

src/renderer/src/stores/settings.ts (1)

457-592: Critical fix: await stored models retrieval to prevent logic errors.

The addition of await on line 462 is essential. Without it, storedModels would be a Promise (always truthy) rather than the resolved array, causing the conditional logic on line 464 and the merging logic in lines 465–511 to malfunction. This fix ensures the promise resolves before dependent operations proceed, bringing it into alignment with the similar pattern used for getDbProviderModels on line 460.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}