Fixed second screen forecast icon and PoP. Added night icons processing. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - added 4 night time icons - added converter-tool to generate c code from own pictures Dependency: - Until/if merge to squix87 branch occurs, use https://github.com/lorol/esp8266-weather-station replacement library and uncomment #define NIGHTICONS in WundergroundConditions.h and WundergroundForecast.h
lorol
changed the title
Added an improvized hack to override Arduino IDE board menus to add a "global" custom -D define
Deep Sleep/Wake replaced with screen off/on. Touch over WiFi icon forces the update from Internet Touch over Battery icon turns screen off. Touch (and hold) the lower part of screen turns screen on. When screen is on touching the lower part of screen toggles 12/24h clock format. 12h clock = auto screen off (after 10 min). Clock / date are hidden until synchronized.
Icon's / main logo corrections. Added reference picture's files.
Display tool minor modification new-icons removed
(An alternative way for only two WiFi credentials, see SVN Rev.63) AC symbol inside battery - preparing to process a battery charger in future
Member
|
There's certainly some goodness in here but we can't merge it as-is. Please prepare individual and isolated change sets for individual features. Smaller PRs are much easier to reason about and they stand a much better change for timely review and merge. |
Author
|
Understand ... but maybe later. I hope meanwhile someone will get my ideas and made them merge-able :) On my devices the hack just work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Dependency:
uncomment #define NIGHTICONS in WundergroundConditions.h and WundergroundForecast.h
More details at: Forecast last entry has wrong icon #39