Skip to content

Conversation

@cxandy
Copy link
Contributor

@cxandy cxandy commented Jul 20, 2017

No description provided.

@squix78 squix78 merged commit 3ee59a7 into ThingPulse:master Jul 22, 2017
@squix78
Copy link
Collaborator

squix78 commented Jul 23, 2017

Hi cxandy. Thank you so much for your contribution. I am really unsure how to proceed here but while I think it would be great to have support for more hardware I also think all the #ifdefs make the code much harder to understand. One very important goal is that the code is a starting point for beginners and the compiler switches make this a lot harder to understand. So I suggest that I will set a link to your AZMZ repository but will remove the compiler switches (and with this hardware support for the AZSMZ HW. I hope you understand... Would you like me to set the link?

@lorol
Copy link

lorol commented Sep 15, 2017

Hi cxandy & squix78.
Could you please merge the nice battery percent bar implementation, say conditionally by #define BAT of course, and add some info about voltage divider resistor values as well as the battery type designed for?
I believe it is pretty generic to allow other people to play even without specific battery charging management board.
Best Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants