Time period #128
Merged
Time period #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for missing reset sleep timer for screen press. New option of Background light off sleep also delays download of weather data
Restore Settings.h
Fix for 24/12 hr time display in - ForecastDetail - ForecastTable - drawAstronomy
SillyHats
suggested changes
Apr 28, 2021
Contributor
Author
|
Nice 8:00 PM is better then 08:00 PM for the 12 HR format |
12Hr format
Fix 12hr time format for sunrise sunset
TiVoHomeUser
commented
May 3, 2021
Contributor
Author
TiVoHomeUser
left a comment
TiVoHomeUser
left a comment
There was a problem hiding this comment.
Fix for Sleep mode and added Light off sleep mode with screen press wake
Change for 12/24 hr format in forcast
Contributor
Author
|
Ready |
Contributor
Author
|
Fixed conflicts any thing more I need to do? |
Member
|
😢 😞 so sorry I missed to review this in due time. Hope I'll find some time next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124 & #127.
This PR is compliant with the other contributing guidelines as well (if not, please describe why).
I have thoroughly tested my contribution.
Should this code require changes to documentation I will contribute those to https://github.com/ThingPulse/docs.
Fix for broken sleep mode
Soft sleep mode
Fix for 12/24 hr displays not changing