MAX_FORECASTS duplicated

[reiyawea]

MAX_FORECASTS exists in both settings.h and esp8266-weather-station-color.ino.
In settings.h, it is unused and its value 10 is wrong (should be 12 since 12 forecasts are to be displayed). So it should be removed.

[marcelstoer]

Good catch, thanks! Those settings are really inconsistent. IMO it would be more desirable to move lines 60-77 from esp8266-weather-station-color.ino to settings.h don't you think?

[reiyawea]

Good catch, thanks! Those settings are really inconsistent. IMO it would be more desirable to move lines 60-77 from esp8266-weather-station-color.ino to settings.h don't you think?

I'm afraid that it might be better to keep those lines. They are more likely to be considered "constants" or "parameters" instead of "settings", since most users may not want to change them at all. I personally think that "settings.h" should keep those must-be-set-by-user things, ie, program won't work with them unchanged.

[marcelstoer]

True, that's one way to look at it.