Forecast last entry has wrong icon

[ccpetersen]

On the last page of the Forecast display the last entry has an icon, cloud with ? mark which is not correct.

[G6EJD]

I thought the Weather Underground icons were used, in which case they do have clouds with a question mark to denote unknown weather, see here: https://www.wunderground.com/weather/api/d/docs?d=resources/icon-sets

[ccpetersen]

It's always the last entry on the second "Forecast" page and it never varies. The text description for that entry is also null. I have another project using the json data for this local and its "Forecast" is correct so I suspect it's not being parsed correctly here. I'll have a look at the code later today.

BTW the weather icons used are in weathericons.h, not the WU icons.

[ccpetersen]

So far I've found that forecasts[i].forecastIcon returns "nt_clear" for the last entry. getMiniMeteoconIconFromProgmem() and GetShortText() don't know how to handle that entry. If you add "nt_clear" to these functions and return "clear" and "Clear" respectively it works.

Have to find out why "nt_clear" is returned.

[lorol]

ccpetersen, thanks for the analyses. nt_xxxxxx seem to be for "night time". You can either add nt_ support resources or cut the nt_

[ccpetersen]

All entires on the forecast screens, except the last one, handle the conversion from nt_xxxxx already. My question still is, why is the last entry different.

Hopefully I'll have some time this week to track down the problem.

[lorol]

Basically there are 2 issues. One is due to overlapping identical keys when scanning the forecast json, the simplified section with manipulated index overrides.

The second issue is missing night time icon's byte arrays. It shows once you try to fix 1) so you either have to manipulate the string by cutting nt_ (then points to daily) which will show you sunny picture for the night, or better add the night time icons.
@squix78 Daniel, Is there a software to create a compatible 2-bits depth arrays from, say BMP?
We need to add 2 more icons with moon instead of sun, all the rest can be handled by daily ones:

1. nt_mostlycloudy = nt_mostlysunny = nt_partlycloudy = nt_partlysunny
2. nt_sunny = nt_clear

[herrold]

@lorol asked
... Is there software to create a compatible 2-bits depth arrays from, say BMP

The FOSS offerings of:

• ImageMagick (has the 'convert' command line tool)
• The Gimp (full blown graphical suite)

come to mind. I have used 'convert' for years to make 'older' formats such as .xpm and so forth

[G6EJD]

LCD image converter can do that: http://www.riuson.com/lcd-image-converter
But the final file needs to be converted to XBM format and there are a few online converters for that part.

[lorol]

Nevermind,

Nothing worked off-the-shelf. It is too custom. Good luck with tries it will not work anyway, I did try enough and will be very curious to see the opposite!

So ... I made myself a converter that creates this custom 2-bpp 4-colors width-rounded C array from a standard picture. You only have to use/ filter your image to have black, white, yellow and 7BC6E6 blue color. All other colors are mapped automatically down to the 4 choices in the output array. Here is the result, after fixing the missing nt_

[BoxOfSnoo]

Thanks @lorol - do you have some code for that that we can use?

[lorol]

Yes here I posted a link to my tool: https://support.squix.org/133/tools-for-making-bitmaps-for-wx-color
If you need, I can add later my project .cpp and .ino files changes I made to get this working.

[BoxOfSnoo]

Thanks! You should create a pull request so it can be merged into the main code, too.

[lorol]

I prefer to leave @squix78 to consider and implement my changes with no messing with code tree.
BTW, if any of my 4 added night pictures (2 big + 2 small) of the zip show scrambled on TFT, please use some new graphics and convert by the tool I just updated.

[lorol]

Here are all changed files and added night time icons, I used to fix the issue (updated Sep. 28, 2017)

If you don't want to use my night hacks, but only you want to fix the last two forecasts icon entries, you can just change following in WundergroundForecast.cpp file:

if (currentKey == "icon" && currentForecastPeriod < maxForecasts) {
to
if (currentKey == "icon" && isSimpleForecast && currentForecastPeriod < maxForecasts) {

and
if (currentKey == "pop" && currentForecastPeriod < maxForecasts) {
to
if (currentKey == "pop" && !isSimpleForecast && currentForecastPeriod < maxForecasts) {
(takes 2 values)

That's it.