Add 2nd HW I2C support #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a note about this feature to the README e.g. at https://github.com/ThingPulse/esp8266-oled-ssd1306#i2c-with-wireh. |
Add 2nd HW I2C support
|
Upated README.md |
thijstriemstra
suggested changes
Jul 28, 2020
README.md
Outdated
| @@ -76,6 +76,8 @@ The library supports different protocols to access the OLED display. Currently t | |||
| SSD1306Wire display(0x3c, SDA, SCL); // ADDRESS, SDA, SCL | |||
| // for 128x32 displays: | |||
| // SSD1306Wire display(0x3c, SDA, SCL, GEOMETRY_128_32); // ADDRESS, SDA, SCL, GEOMETRY_128_32 (or 128_64) | |||
| // for using 2nd Hardware I2C (if availbale) | |||
There was a problem hiding this comment.
typo here, should say 'available'
Add 2nd HW I2C support
|
@benoitm974 can you also add this for SH1106? |
ok it's done for SH1106 |
|
awesome, thanks, works great. |
|
Benoit, thanks for writing such clear in-code documentation. |
thijstriemstra
suggested changes
Aug 3, 2020
README.md
Outdated
| @@ -84,6 +89,9 @@ for a SH1106: | |||
| #include "SH1106Wire.h" | |||
|
|
|||
| SH1106Wire display(0x3c, SDA, SCL); // ADDRESS, SDA, SCL | |||
| // By default SD1306Wire set I2C frequency to 700000, you can use set either another frequency or skip setting the frequency by providing -1 value | |||
There was a problem hiding this comment.
this should be SH1106Wire. I would use 'By default the I2C frequency of SH1106Wire is 700000, you can use another frequency or skip setting the frequency by providing -1 value' etc
thijstriemstra
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I needed to use the second I2C channel on ESP32 I propose a change to SSD1306Wire file.