Skip to content

Commit f00e723

Browse files
authored
v2.2.0
* fix(storage): uploadFile gets downloadURL before writing metadata - prescottprue#487, prescottprue#488 * fix(storage): add unit tests for `fileMetadataFactory` (config level) and `metadataFactory` (option for uploadFile) to confirm downloadURL is available before writing metadata - prescottprue#487, prescottprue#488 * fix(storage): fix downloadURL error in file upload metadata - @jpierce42 * fix(auth): `LOGOUT` action dispatch only include preserve parameter if provided in settings (not when undefined) * fix(profile): profile update on login works with email login (used to require `createUser`) - prescottprue#475 * feat(HOCs): optimize firestoreConnect unset / set listeners - @demoran23 * fix(HOCs): firestoreConnect no longer requires store.firebase (only attaches to props if available) * fix(auth): move detaching of profile listeners before `signOut` within `logout` method to fix `permission_denied` errors - prescottprue#494 * fix(enhancer): support config already existing on store - [132 of redux-firestore](prescottprue/redux-firestore#132)
2 parents c4f3ee4 + e3bc8ec commit f00e723

File tree

14 files changed

+4039
-3327
lines changed

14 files changed

+4039
-3327
lines changed

.eslintrc

-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ plugins: [babel, react, prettier]
88
env:
99
browser: true
1010
es6: true
11-
jasmine: true
12-
node: true
1311

1412
rules:
1513
semi: [2, 'never']

.travis.yml

+10-6
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,16 @@ language: node_js
55
node_js:
66
- 6 # Maintenance
77
- 8 # Active
8-
- 10 # Current release
8+
- 10
99

1010
notifications:
11-
# Only send notifications when travis status changes
1211
email:
12+
# Only send notifications when travis status changes
1313
on_failure: change
1414
on_success: change
1515

16-
addons:
17-
code_climate:
18-
repo_token: $CODE_CLIMATE
19-
2016
cache:
17+
bundler: true
2118
directories:
2219
- $HOME/.npm
2320

@@ -26,10 +23,17 @@ branches:
2623
- master
2724
- next
2825

26+
install:
27+
- npm i
28+
2929
script:
3030
- npm run lint
3131
- npm run test:cov
3232

33+
addons:
34+
code_climate:
35+
repo_token: $CODE_CLIMATE
36+
3337
deploy:
3438
- provider: npm
3539
skip_cleanup: true

docs/recipes/upload.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,14 @@ When uploading files as in the above example, you can modify how the file's meta
8383

8484
// within your createStore.js or store.js file include the following config
8585
const config = {
86-
fileMetadataFactory: (uploadRes) => {
86+
fileMetadataFactory: (uploadRes, firebase, metadata, downloadURL) => {
8787
// upload response from Firebase's storage upload
88-
const { metadata: { name, fullPath, downloadURLs } } = uploadRes
88+
const { metadata: { name, fullPath } } = uploadRes
8989
// default factory includes name, fullPath, downloadURL
9090
return {
9191
name,
9292
fullPath,
93-
downloadURL: downloadURLs[0]
93+
downloadURL
9494
}
9595
}
9696
}

0 commit comments

Comments
 (0)