Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to tune adam_beta1 and adam_beta2 parameters using simple transformers, yet there are available to tune using huggingface #1423

Closed
anaconda121 opened this issue Jun 11, 2022 · 2 comments
Labels
stale This issue has become stale

Comments

@anaconda121
Copy link
Contributor

anaconda121 commented Jun 11, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Refer to title^^

Describe the solution you'd like
A clear and concise description of what you want to happen.
Make it possible for the parameters adam_beta1 and adam_beta2 to be added to the list of parameters for ClassifcationArgs(). The pull request (huggingface/transformers#5592) addressed these feature in hugging face.

Additional context
Add any other context or screenshots about the feature request here.
image
I attempted to add adam_beta1 and adam_beta2 to ClassificationArgs(), but as expected, I got an error saying they weren't defined. Image below:
image

@anaconda121
Copy link
Contributor Author

Just put up some PRs to fix this issue. For some reason when I made edits to multiple files it created different PRs, apologies for any inconveniencies this may cause. Let me know what you think!

#1424
#1425

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This issue has become stale label Sep 21, 2022
@stale stale bot closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue has become stale
Projects
None yet
Development

No branches or pull requests

1 participant