Programming Challenge redislabs-training#4

Author: ThiernoAmirouDiallo

src/main/java/com/redislabs/university/RU102J/dao/CapacityDaoRedisImpl.java

@@ -3,63 +3,65 @@
 import com.redislabs.university.RU102J.api.CapacityReport;
 import com.redislabs.university.RU102J.api.MeterReading;
 import com.redislabs.university.RU102J.api.SiteCapacityTuple;
-import redis.clients.jedis.*;
 
 import java.util.List;
 import java.util.Set;
 import java.util.stream.Collectors;
 
+import redis.clients.jedis.Jedis;
+import redis.clients.jedis.JedisPool;
+import redis.clients.jedis.Pipeline;
+import redis.clients.jedis.Response;
+import redis.clients.jedis.Tuple;
+
 public class CapacityDaoRedisImpl implements CapacityDao {
 
-    private final JedisPool jedisPool;
-
-    public CapacityDaoRedisImpl(JedisPool jedisPool) {
-        this.jedisPool = jedisPool;
-    }
-
-    @Override
-    public void update(MeterReading reading) {
-        String capacityRankingKey = RedisSchema.getCapacityRankingKey();
-        Long siteId = reading.getSiteId();
-
-        double currentCapacity = reading.getWhGenerated() - reading.getWhUsed();
-
-        try (Jedis jedis = jedisPool.getResource()) {
-            jedis.zadd(capacityRankingKey, currentCapacity, String.valueOf(siteId));
-        }
-    }
-
-    @Override
-    public CapacityReport getReport(Integer limit) {
-        CapacityReport report;
-        String key = RedisSchema.getCapacityRankingKey();
-
-        try (Jedis jedis = jedisPool.getResource()) {
-            Pipeline p = jedis.pipelined();
-            Response<Set<Tuple>> lowCapacity = p.zrangeWithScores(key, 0, limit-1);
-            Response<Set<Tuple>> highCapacity = p.zrevrangeWithScores(key, 0,
-                    limit-1);
-            p.sync();
-
-            List<SiteCapacityTuple> lowCapacityList = lowCapacity.get().stream()
-                    .map(SiteCapacityTuple::new)
-                    .collect(Collectors.toList());
-
-            List<SiteCapacityTuple> highCapacityList = highCapacity.get().stream()
-                    .map(SiteCapacityTuple::new)
-                    .collect(Collectors.toList());
-
-            report = new CapacityReport(highCapacityList, lowCapacityList);
-        }
-
-        return report;
-    }
-
-    // Challenge #4
-    @Override
-    public Long getRank(Long siteId) {
-        // START Challenge #4
-        return -2L;
-        // END Challenge #4
-    }
+	private final JedisPool jedisPool;
+
+	public CapacityDaoRedisImpl( JedisPool jedisPool ) {
+		this.jedisPool = jedisPool;
+	}
+
+	@Override
+	public void update( MeterReading reading ) {
+		String capacityRankingKey = RedisSchema.getCapacityRankingKey();
+		Long siteId = reading.getSiteId();
+
+		double currentCapacity = reading.getWhGenerated() - reading.getWhUsed();
+
+		try ( Jedis jedis = jedisPool.getResource() ) {
+			jedis.zadd( capacityRankingKey, currentCapacity, String.valueOf( siteId ) );
+		}
+	}
+
+	@Override
+	public CapacityReport getReport( Integer limit ) {
+		CapacityReport report;
+		String key = RedisSchema.getCapacityRankingKey();
+
+		try ( Jedis jedis = jedisPool.getResource() ) {
+			Pipeline p = jedis.pipelined();
+			Response<Set<Tuple>> lowCapacity = p.zrangeWithScores( key, 0, limit - 1 );
+			Response<Set<Tuple>> highCapacity = p.zrevrangeWithScores( key, 0, limit - 1 );
+			p.sync();
+
+			List<SiteCapacityTuple> lowCapacityList = lowCapacity.get().stream().map( SiteCapacityTuple::new ).collect( Collectors.toList() );
+
+			List<SiteCapacityTuple> highCapacityList = highCapacity.get().stream().map( SiteCapacityTuple::new ).collect( Collectors.toList() );
+
+			report = new CapacityReport( highCapacityList, lowCapacityList );
+		}
+
+		return report;
+	}
+
+	// Challenge #4
+	@Override
+	public Long getRank( Long siteId ) {
+		// START Challenge #4
+		try ( Jedis jedis = jedisPool.getResource() ) {
+			return jedis.zrevrank( RedisSchema.getCapacityRankingKey(), String.valueOf( siteId ) );
+		}
+		// END Challenge #4
+	}
 }

src/test/java/com/redislabs/university/RU102J/dao/CapacityDaoRedisImplTest.java

@@ -71,7 +71,6 @@ public void getReport() {
     }
 
     // Challenge #4
-    @Ignore
     @Test
     public void getRank() {
         CapacityDao dao = new CapacityDaoRedisImpl(jedisPool);