fix: omit packager assets from caching #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
force-pushed
the
fix-video-caching-local-video
branch
from
9d2035f
to
0c0ca88
Compare
n1ru4l
force-pushed
the
fix-video-caching-local-video
branch
from
0c0ca88
to
3df20ff
Compare
cobarx
reviewed
Jan 23, 2019
There was a problem hiding this comment.
Hi Laurin,
Just looking this over it appears good to me aside from a minor path cleanup comment that I've left you. Is there anything specific that you want me to review in depth? If you're happy with it, I'm pretty sure this is safe to merge, you've got commit privileges so go ahead :)
cobarx
reviewed
Jan 23, 2019
AnteWall
pushed a commit
to sfstudios/react-native-video
that referenced
this pull request
Mar 1, 2019
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
(rebased from commit 125d5dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation
No updates needed since this is a bug fix
Update the changelog
Done.
Provide an example of how to test the change
I added a button to the
examples/video-cachingwhich allows to change the source to a packager resolved video.Describe the changes
Enabling video-caching resulted in issues with playing packager resolved video assets (
require('./video.mp4')orimport VideoSource from './video.mp4') in the development environment.