[BUG]: EXC_BREAKPOINT superview (RCTVideo.handleViewControllerOverlayViewFrameChange(RCTVideo.swift:1551))

[ngima]

Version

v6.2.0

What platforms are you having the problem on?

iOS

System Version

mostly v17.5.1, also v16.1

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

Getting Sentry error for iOS

EXC_BREAKPOINT
Level: Fatal
Unhandled
superview

RCTVideo.handleViewControllerOverlayViewFrameChange(RCTVideo.swift:1551)

in react-native-video v6.2.0

Screenshot:

Reproduction

repository link

Reproduction

Step to reproduce this bug are:
I have not been able to reproduce it myself but I have been getting it since I upgraded from v6.1.1 to v6.2.0

[ngima]

Could be related to #3889

[moskalakamil]

Hi, thanks for reporting issue!

[ngima]

@moskalakamil you're welcome,

Thanks for the response

do you think it's something that could have fixed in the latest versions? Or it's still need to be fixed?

If not sure, I will upgrade to the latest version v6.4.5 and wait for the crashlytics.

[ngima]

@moskalakamil

Interesting finding,

I upgraded the app to latest but now I have a weird bug in Android.

I have custom control implementation and I am leveraging following functions to going to fullScreenMode but with my custom controls overlays.

videoRef.current?.setFullScreen(true) // in new version
videoRef.current?.presentFullscreenPlayer() // in old version

After the change when going to full screen now I get it with full screen without my overlays (seems like it's not possible anymore like in iOS) but with default player controls.

Is it a bug or we're now trying to support fullscreen mode by default within react-native-video ?

[seyedmostafahasani]

@moskalakamil

Interesting finding,

I upgraded the app to latest but now I have a weird bug in Android.

I have custom control implementation and I am leveraging following functions to going to fullScreenMode but with my custom controls overlays.

videoRef.current?.setFullScreen(true) // in new version
videoRef.current?.presentFullscreenPlayer() // in old version

After the change when going to full screen now I get it with full screen without my overlays (seems like it's not possible anymore like in iOS) but with default player controls.

Is it a bug or we're now trying to support fullscreen mode by default within react-native-video ?

Please see my comment here.

[github-actions]

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.