Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video poster disappears after putting app in background for audio files #2800

Closed
jrhager84 opened this issue Aug 3, 2022 · 3 comments
Closed
Assignees
Labels

Comments

@jrhager84
Copy link

Bug

poster disappears with audioOnly after app goes into background

Platform

iOS & Android
Which player are you experiencing the problem on:

  • iOS
  • Android

Environment info

React native info output:

 System:
    OS: macOS 12.5
    CPU: (10) arm64 Apple M1 Max
    Memory: 3.70 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.6.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.15.1 - /opt/homebrew/bin/npm
    Watchman: 2022.07.04.00 - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.1 AI-211.7628.21.2111.8309675
    Xcode: 13.4/13F17a - /usr/bin/xcodebuild
  Languages:
    Java: 18.0.1 - /opt/homebrew/opt/openjdk/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.68.1 => 0.68.1 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 5.2.0

Steps To Reproduce

  1. Instantiate a Video with just audio.
  2. Set poster
  3. Put app in background
  4. Go back into app

Expected behaviour

  1. Poster should remain
@freeboub
Copy link
Collaborator

freeboub commented Aug 20, 2022

Poster management is fully done in JS (see Video.js file).
By reviewing the code I don't find the root cause, but I am sure you can find it ! :) ( and provide a pull request to fix it :D )

Edit: do you use the audioOnly prop ?

@freeboub
Copy link
Collaborator

freeboub commented Apr 2, 2024

I removed audioOnly prop as it bring unexpected JS code ...
I advise to move poster management on application side to ensure the behavior is the expected one with your app

@freeboub
Copy link
Collaborator

freeboub commented Apr 5, 2024

linked PR merged, let's close this issue

@freeboub freeboub closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants