Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pictureInPicture={false} is not working #2373

Closed
nealwwilliams opened this issue May 19, 2021 · 11 comments
Closed

pictureInPicture={false} is not working #2373

nealwwilliams opened this issue May 19, 2021 · 11 comments
Labels
Platform: iOS stale Closed due to inactivity or lack or resources

Comments

@nealwwilliams
Copy link

I have pictureInPicture set to false but the setting is ignored. When I swipe up the app goes to background and video goes to picture-in-picture. I have picture-in-picture enabled in xcode only because I also need background audio for other features of the app. I have pictureInPicture, playInBackground both set to false. iOS 14.5

			<Video source={this.state.videoSrc} 
				ref={(ref) => { this.player = ref }}                                     
				resizeMode={'cover'}
				style={styles.video}
				onProgress={this.videoProgress}
				controls={true}
				pictureInPicture={false}
				playInBackground={false}
			/>

Library version: 5.1.1

@chungmarcoo
Copy link

chungmarcoo commented May 20, 2021

Same issue, when I click the home button on my iPad and intented to back to home screen. The video turns into "picture-in-picture" mode even set pictureInPicture={false}.

@zchwyng
Copy link
Contributor

zchwyng commented Jun 10, 2021

+1

@annguyen-iosdev
Copy link

annguyen-iosdev commented Sep 22, 2021

+ 1, any update guys?

@yev-yev-yev
Copy link

+1 Same here

@jeffbonasso-ambifi
Copy link

+1

@jeffbonasso-ambifi
Copy link

It's not an ideal user experience because you see it closing in the top right and when go to task manager still says in picture in picture but it does not keep it in picture in picture if you set all these like this...

playInBackground={true}
playWhenInactive={true} 
ignoreSilentSwitch="silent"
pictureInPicture={false}

@vmseba
Copy link

vmseba commented Apr 21, 2022

I'm experiencing this issue on an iOS app, looking at the source code it seems that setupPipController is not checking if pictureInPicture has been enabled or not. I've been able to fix this by patching the library and adding that check.

@Artem2001S
Copy link

This change helped me
48f524c

@hueniverse hueniverse added the stale Closed due to inactivity or lack or resources label Jun 22, 2022
@jcksncllwy
Copy link

jcksncllwy commented May 6, 2023

Version 5.2.1

I'm using the video player as a screen background and unfortunately the video pops out into picture-in-picture whenever a user opens the App Switcher. It seems like I should be able to prevent this behavior with the pictureInPicture prop, but it's not working.

I think this issue may have resurfaced. It looks like maybe the pictureInPicture prop was left by the wayside during the Swift conversion? #2527

@dianamelga
Copy link

@hueniverse I'm having this same issue on v5.2.1

@Hanuman-Ghawade
Copy link

I am facing the same issue. Please help out if there is any solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS stale Closed due to inactivity or lack or resources
Projects
None yet
Development

No branches or pull requests