Skip to content

Fixed blue LED bug with cayenne LPP device #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

simmoinard
Copy link
Contributor

I had problems with my Things nodes (after several time, it freezes on fixed blue light). The problem has been solved on the forum (https://www.thethingsnetwork.org/forum/t/the-things-node-new-low-power-library-development/12521/144?u=simmoinard)
The "Basics.ino" file has been updated with a simple Delay(50), but not the "CayenneLPP.ino" ...

I had problems with my Things nodes (after several time, it freezes on fixed blue light). The problem has been solved on the forum (https://www.thethingsnetwork.org/forum/t/the-things-node-new-low-power-library-development/12521/144?u=simmoinard)
and the Basics.ino has been update with a simple Delay(50), but not the CayenneLPP.ino ...
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch. Two minor code style things.

@@ -119,6 +119,9 @@ void sendData(uint8_t port)

// Set RN module to sleep mode
ttn.sleep(60000);
// This one is not optionnal, remove it
// and say bye bye to RN2983 sleep mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comment. While you're at it, also on line 101.

@simmoinard
Copy link
Contributor Author

Done !

@johanstokking
Copy link
Member

Thanks!

@johanstokking johanstokking merged commit 780168c into TheThingsNetwork:master Oct 5, 2018
@johanstokking
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants