Change: Remove Rally Point button from all command sets

[xezon]

This change has been reverted with #1851

This change removes the Rally Point button from all command sets. It will not be missed.

Rationale

The button is obsolete. Rally Point functionality is always enabled as long as structure is selected.

Original

Patched

[commy2]

I remember someone objecting to this change when I made it in my project. I don't remember why though. As far as I can tell, this button is completely pointless.

[MTKing4]

I agree that it is pointless, but I'm not a fan of removing things that could help newcomers to the game if any, especially if we're not in dire need of that extra slot currently

[xezon]

In what way does it help newbies though? Clicking this button really changes nothing. The only this this button does it tell that this structure has Rally Points.

[MTKing4]

Yeah in case there's someone confused and doesn't know anything about RTS and Wondering what does the flag does, he can read the command button to understand

Basic RTS tutorial in Essence.

[commy2]

Set Rally Point

Tooltip:

Set the rally point for this building

Idk if that ever helped anyone.

[MTKing4]

Yeah I'm not too fussed about removing it either, just stating what the purpose of it was wether it helped anyone in the past or not.

[commy2]

If ingame info about rallypoints is truly needed (I don't think so personally), then it should be placed better than on a button that does absolutely nothing. I mean, this thing is more confusing right now than clearing up anything, because the button does literally nothing at all (as far as I can tell). Not even change cursor or anything.

[MTKing4]

Placed better like where?

[commy2]

Anywhere really. Anywhere that is not a useless button, that can be clicked, but nothing happens for some reason.

[xezon]

Merge this?

[xezon]

By coincidence I noticed that the button was not removed from Superweapon Command Center. Fixed. Documentation added. Looks good.

[kABUSE1]

There is a situational difference between having the command button and not having it:

2023-04-16.14-48-36.mp4

If you have the command button you can place the rally point into a group of units via the hotkey without accidentally selecting any of them.

I only noticed after looking for a difference, I Have never done this in an actual match.

[xezon]

Ohh. So it does make a difference. Well then we can revert this change again :D

[kABUSE1]

So let's do the opposite, the boss general airfield is lacking this command button by default lmao

[kABUSE1]

Please also take this into consideration:
#1985

(Nevermind, current issue is already closed. I am still in the progress of understading how git works lol)

[xezon]

This change was merged and reverted.