[GEN] Backport collision test related changes and fixes in WWMath from Zero Hour #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change unifies the remaining code of WWMath.
Generals inherits the following changes:
As far as I could tell, the collision math changes in colmathaabox, colmathaabtri, colmathobbtri are never called in Zero Hour (should have checked Generals but it is probably the same). So these math changes are probably inconsequential. If there were actual game logic relevant collisions using this code, it could incur behaviour changes.
Regarding CollisionContext, there appears to be a relevant comment nearby:
The math changes are split into separate commits to make testing of older changes easier if we ever wanted to revisit a particular change.